FreeRTOS+TCP Zynq: check frame type before calculating ICMP checksum (v3) #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AniruddhaKanhere
previously approved these changes
Sep 28, 2020
Member
|
/bot run checks |
gkwicker
suggested changes
Sep 28, 2020
| #define iptraceEMAC_TASK_STARTING() do {} while( ipFALSE_BOOL ) | ||
| #endif | ||
|
|
||
| /* Default the size of the stack used by the EMAC deferred handler task to twice |
Contributor
There was a problem hiding this comment.
This comment no longer matches the constant at line 87.
AniruddhaKanhere
approved these changes
Sep 29, 2020
Member
|
/bot run checks |
Contributor
Author
|
This PR has moved to FreeRTOS-Plus-TCP PR #19. |
moninom1
pushed a commit
that referenced
this pull request
Sep 14, 2022
…dress (#304) Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: alfred gedeon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will replace the earlier #177, of which the branch got lost.
The only significant change is in the function
xNetworkInterfaceOutput(), in which the frame-type is checked before checking the protocol type.I the current driver, outgoing ARP frames get a size warning. It doesn't cause incorrect behaviour, except for the size warnings in the logging.
Test Steps
Define
ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUMas1and send an outgoing ping. The ARP before the PING may not trigger a size warning, and the ICMP checksum shall be calculated correctly.Related Issue
None.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.