Skip to content

Conversation

@TakayukiMatsuo
Copy link
Contributor

Add FreeRTOS_Plus_WolfSSL_FIPS_Ready_Windows_Simulator

Description

This demo project is created to show how the wolfSSL-FIPS-Ready version works and how to use it to build with the demo application.

This demo project contains the latest wolfSSL-FIPS-Ready version (v4.5.0). Also, in this demo, the unused wolfSSL files for building the demo application have been removed.

Test Steps

Build RTOSDemo.exe with the solution file in the FreeRTOS-Plus/Demo/FreeRTOS_Plus_WolfSSLFIPS_Ready_Windows_Simulator and then run it with Debugger.

However, the demo application will fail for the first run. An error is expected at this point. Extra steps are required to build the application including wolfSSL-FIPS-Ready version. Please refer the "How to build and run the Demo application" section in the FreeRTOS-Plus/Demo/FreeRTOS_Plus_WolfSSL_FIPS_Ready_Windows_Simulator/README_wolfSSL_FIPS_ready.md.

Related Issue

None

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

TakayukiMatsuo and others added 14 commits July 31, 2020 17:48
# Conflicts:
#	FreeRTOS-Plus/Demo/FreeRTOS_Plus_WolfSSL_Windows_Simulator/WIN32.vcxproj
#	FreeRTOS-Plus/Demo/FreeRTOS_Plus_WolfSSL_Windows_Simulator/WIN32.vcxproj.filters
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/compile
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/config.guess
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/config.sub
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/depcomp
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/install-sh
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/ltmain.sh
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/missing
#	FreeRTOS-Plus/Source/WolfSSL/build-aux/test-driver
#	FreeRTOS-Plus/Source/WolfSSL/certs/1024/client-cert.der
#	FreeRTOS-Plus/Source/WolfSSL/certs/1024/client-cert.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/1024/include.am
#	FreeRTOS-Plus/Source/WolfSSL/certs/ca-cert.der
#	FreeRTOS-Plus/Source/WolfSSL/certs/ca-cert.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/client-cert.der
#	FreeRTOS-Plus/Source/WolfSSL/certs/client-cert.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/client-ecc-cert.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/crl/cliCrl.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/crl/crl.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/crl/crl.revoked
#	FreeRTOS-Plus/Source/WolfSSL/certs/crl/eccCliCRL.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/crl/eccSrvCRL.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/crl/include.am
#	FreeRTOS-Plus/Source/WolfSSL/certs/include.am
#	FreeRTOS-Plus/Source/WolfSSL/certs/ntru-cert.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/ntru-key.raw
#	FreeRTOS-Plus/Source/WolfSSL/certs/server-cert.der
#	FreeRTOS-Plus/Source/WolfSSL/certs/server-cert.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/server-ecc-comp.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/server-ecc-rsa.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/server-ecc.pem
#	FreeRTOS-Plus/Source/WolfSSL/certs/taoCert.txt
#	FreeRTOS-Plus/Source/WolfSSL/certs/wolfssl-website-ca.pem
#	FreeRTOS-Plus/Source/WolfSSL/ctaocrypt/src/misc.c
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/callbacks.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/crl.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/aes.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/arc4.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/asn.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/asn_public.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/blake2-impl.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/blake2-int.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/blake2.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/camellia.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/chacha.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/coding.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/compress.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/des3.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/dh.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/ecc.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/error-crypt.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/fips_test.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/integer.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/logging.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/md4.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/md5.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/memory.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/misc.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/mpi_class.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/mpi_superclass.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/pkcs7.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/poly1305.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/pwdbased.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/random.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/ripemd.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/rsa.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/settings.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/settings_comp.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/sha.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/sha256.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/sha512.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/tfm.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/types.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/visibility.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ctaocrypt/wc_port.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/error-ssl.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/include.am
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/internal.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ocsp.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/des.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/dsa.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/evp.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/hmac.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/include.am
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/rsa.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/openssl/ssl.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/options.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/sniffer.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/sniffer_error.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/ssl.h
#	FreeRTOS-Plus/Source/WolfSSL/cyassl/version.h
#	FreeRTOS-Plus/Source/WolfSSL/doc/README.txt
#	FreeRTOS-Plus/Source/WolfSSL/doc/include.am
#	FreeRTOS-Plus/Source/WolfSSL/examples/client/client.c
#	FreeRTOS-Plus/Source/WolfSSL/examples/client/client.h
#	FreeRTOS-Plus/Source/WolfSSL/examples/client/client.vcproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/client/client.vcxproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/client/include.am
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoclient/echoclient.c
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoclient/echoclient.h
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoclient/echoclient.vcproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoclient/echoclient.vcxproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoclient/include.am
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoserver/echoserver.c
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoserver/echoserver.h
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoserver/echoserver.vcproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoserver/echoserver.vcxproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/echoserver/include.am
#	FreeRTOS-Plus/Source/WolfSSL/examples/server/include.am
#	FreeRTOS-Plus/Source/WolfSSL/examples/server/server.c
#	FreeRTOS-Plus/Source/WolfSSL/examples/server/server.h
#	FreeRTOS-Plus/Source/WolfSSL/examples/server/server.vcproj
#	FreeRTOS-Plus/Source/WolfSSL/examples/server/server.vcxproj
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_add_am_macro.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_am_jobserver.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_am_macros.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_append_compile_flags.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_append_flag.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_append_to_file.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_check_compile_flag.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_check_link_flag.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_count_cpus.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_create_generic_config.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_file_escapes.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_harden_compiler_flags.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_print_to_file.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_pthread.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ax_vcs_checkout.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/libtool.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ltoptions.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ltsugar.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/ltversion.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/lt~obsolete.m4
#	FreeRTOS-Plus/Source/WolfSSL/m4/visibility.m4
#	FreeRTOS-Plus/Source/WolfSSL/rpm/spec.in
#	FreeRTOS-Plus/Source/WolfSSL/src/bio.c
#	FreeRTOS-Plus/Source/WolfSSL/sslSniffer/sslSniffer.vcproj
#	FreeRTOS-Plus/Source/WolfSSL/sslSniffer/sslSniffer.vcxproj
#	FreeRTOS-Plus/Source/WolfSSL/sslSniffer/sslSnifferTest/include.am
#	FreeRTOS-Plus/Source/WolfSSL/sslSniffer/sslSnifferTest/snifftest.c
#	FreeRTOS-Plus/Source/WolfSSL/support/wolfssl.pc
#	FreeRTOS-Plus/Source/WolfSSL/swig/README
#	FreeRTOS-Plus/Source/WolfSSL/swig/wolfssl.i
#	FreeRTOS-Plus/Source/WolfSSL/swig/wolfssl_adds.c
#	FreeRTOS-Plus/Source/WolfSSL/tests/api.c
#	FreeRTOS-Plus/Source/WolfSSL/tests/hash.c
#	FreeRTOS-Plus/Source/WolfSSL/tests/include.am
#	FreeRTOS-Plus/Source/WolfSSL/tests/suites.c
#	FreeRTOS-Plus/Source/WolfSSL/tests/test-dtls.conf
#	FreeRTOS-Plus/Source/WolfSSL/tests/test.conf
#	FreeRTOS-Plus/Source/WolfSSL/tests/unit.c
#	FreeRTOS-Plus/Source/WolfSSL/tests/unit.h
#	FreeRTOS-Plus/Source/WolfSSL/testsuite/include.am
#	FreeRTOS-Plus/Source/WolfSSL/testsuite/testsuite.c
#	FreeRTOS-Plus/Source/WolfSSL/testsuite/testsuite.vcproj
#	FreeRTOS-Plus/Source/WolfSSL/testsuite/testsuite.vcxproj
#	FreeRTOS-Plus/Source/WolfSSL/wolfcrypt/src/evp.c
@AniruddhaKanhere
Copy link
Member

/bot run checks

@cobusve
Copy link
Contributor

cobusve commented Oct 22, 2020

Hi TakayukiMatsuo, we pushed some fixes to your branch yesterday but they have now been overwritten since by your force-push from fd735e2 to e095bff. One of the things we fixed is that your commit is deleting this header file which seems to be incorrect.
FreeRTOS/FreeRTOS/Demo/CORTEX_MPU_M7_NUCLEO_H743ZI2_GCC_IAR_Keil/ST_Code/Drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_sd_ex.h

We would like to do a FreeRTOS release shortly and we need to get this resolved ASAP or it will not make it into the release.

Copy link
Contributor

@cobusve cobusve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST_Code/Drivers/STM32H7xx_HAL_Driver/Inc/stm32h7xx_hal_sd_ex.h should not be deleted as part of this PR

Changes we made to version numbers and spelling errors have also been reverted, we need these to merge.

@TakayukiMatsuo
Copy link
Contributor Author

I'm very sorry to trouble you. Should I add the missing header file to this repository?

@cobusve
Copy link
Contributor

cobusve commented Oct 23, 2020

There is a lot of overlap between this PR and #303 it seems. I am going to merge that one and then come back to this one to see what is still outstanding. Since #303 also adds this we may be able to just close this one.

@cobusve
Copy link
Contributor

cobusve commented Oct 26, 2020

@TakayukiMatsuo can you please take a look at this one now that #303 has been merged. We have a number of conflicts that need resolution on this one.

@TakayukiMatsuo
Copy link
Contributor Author

Merging #303 made this PR(#214) unnecessary. I confirmed the FIPS-Ready demo is merged and works. Hence, let me close this PR. Thank you for your help.

@cobusve
Copy link
Contributor

cobusve commented Oct 27, 2020

It is great to hear that the other PR has included this and is working fine. I am closing this one.

@cobusve cobusve closed this Oct 27, 2020
moninom1 pushed a commit that referenced this pull request Sep 14, 2022
* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update proof to use assert with readability check

* Revert ci.yml changes

* Remove unwanted changes

* Null check

* Fix adding NULL checks

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>
moninom1 pushed a commit that referenced this pull request Sep 14, 2022
* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
author Hein Tibosch <[email protected]> 1609879469 +0800
committer Aniruddha Kanhere <[email protected]> 1619029134 -0700

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Create uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

* Remove unused file

Include ICMP while calculating IP header checksum (#198)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Include ICMP checksum

* Uncrustify

* Update ci.yml

* Spell check

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add comment to CI.yml

fix compiler warnings about casting to format string (#197)

* fix compiler warnings about casting to format string

Fix various warnings like:

/FreeRTOS-Plus-TCP/FreeRTOS_IP.c: In function 'FreeRTOS_strerror_r':
/FreeRTOS-Plus-TCP/FreeRTOS_IP.c:3395:60: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=]
             ( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int32_t ) xErrnum );
                                                           ~^   ~~~~~~~~~~~~~~~~~~~
                                                           %ld

* explicitly cast arguments to format string

This should hopefully make the format string compatible
with all architectures.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Added git-secrets check to Github actions (#201)

Add header file to socket.h so that it can be compiled on its own (#204)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

User hook function for handling unsupported Ethernet frames (#200)

* Adds an optional user hook that gets called for all unhandled Ethernet frames.

* re-wording

* Fix spell check

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Limit the number of attempts to resolve an address in xARPWaitResolution() (#206)

Co-authored-by: Hein Tibosch <[email protected]>

Update litani submodule to version 1.6.0 (#210)

[CBMC] Add assert with readability check (#214)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update proof to use assert with readability check

* Revert ci.yml changes

* Remove unwanted changes

* Null check

* Fix adding NULL checks

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add unit-tests for FreeRTOS_ARP.c (#209)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

* First commit

* Cleanup

* Update: working version

* Coverage of eARPGetCacheEntry

* Update

* Unit-test and clenaup

* 100% line and function coverage

* Uncrustify and update

* 100% all coverage

* Move files to correct location

* Fix tests

* uncrustified

* Update ci.yml

* Update

* uncrustify and update after Hein's comments

* Empty commit

* Clenaup after @yanjos-dev's review

* Update CI

* Cleanup - pass 1

* Remove gdb

* Uncrustify

* Remove litani changes

* Clean up

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

DHCP unit test (#211)

Co-authored-by: Aniruddha Kanhere <[email protected]>

Repair buffer leak when replying to NBNS requests (#215)

* Repair buffer leak when replying to NBNS requests

* Applied Uncrustify

* Variable 'pxNewBuffer' was out of scope

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Static allocation, if configSUPPORT_STATIC_ALLOCATION == 1 (#208) (#217)

* Static allocation of tasks and queues, if configSUPPORT_STATIC_ALLOCATION == 1 (#208)

Is not added to any ported network interfaced.

* Build-check fix

* Uncrustify

* Uncrustify v2

* Update FreeRTOS_IP.c

Co-authored-by: Christian Jensen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Add a method to obtain the handle of the FreeRTOS+TCP IP task (#222)

* Add a method to obtain the handle of the FreeRTOS+TCP IP task

* Added the modified FreeRTOS_IP.c

* Update lexicon.txt

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Code changes for unit-testing (#223)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Make some code changes as a precursor for unit-testing

* remove unused file

* Fixed failing checks

* Fixed CBMC proof

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Use an infinite timeout in FreeRTOS_closesocket when called from a user task (#226)

Reformat MPS2_AN385 network driver (#224)

* Update the MPS2_AN385 network driver so it conforms to the +TCP coding and style guide.

* Update smsc9220_eth_drv.c

Remove #warning message erroneously left in.

Co-authored-by: alfred gedeon <[email protected]>

Uncrustify.

Uncrustify again.

Before sending a challenge ACK, check the sequence number more properly (#225)

* Before sending a challenge ACK, check the sequence number more properly

* Make xSequenceLessThan and xSequenceGreaterThan public functions

* Extended comments on two public functions.

* Fix Spell check

* Although no changes were made to MPS2_AN385, some formatting changes to that driver

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Fix Some warnings

* merge tcp_mem_stats

* Add check

* Add 'UL' to an uint32_t value

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
moninom1 pushed a commit that referenced this pull request Sep 14, 2022
* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
author Hein Tibosch <[email protected]> 1609879469 +0800
committer Aniruddha Kanhere <[email protected]> 1619029134 -0700

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Create uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

* Remove unused file

Include ICMP while calculating IP header checksum (#198)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Include ICMP checksum

* Uncrustify

* Update ci.yml

* Spell check

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add comment to CI.yml

fix compiler warnings about casting to format string (#197)

* fix compiler warnings about casting to format string

Fix various warnings like:

/FreeRTOS-Plus-TCP/FreeRTOS_IP.c: In function 'FreeRTOS_strerror_r':
/FreeRTOS-Plus-TCP/FreeRTOS_IP.c:3395:60: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=]
             ( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int32_t ) xErrnum );
                                                           ~^   ~~~~~~~~~~~~~~~~~~~
                                                           %ld

* explicitly cast arguments to format string

This should hopefully make the format string compatible
with all architectures.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Added git-secrets check to Github actions (#201)

Add header file to socket.h so that it can be compiled on its own (#204)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

User hook function for handling unsupported Ethernet frames (#200)

* Adds an optional user hook that gets called for all unhandled Ethernet frames.

* re-wording

* Fix spell check

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Limit the number of attempts to resolve an address in xARPWaitResolution() (#206)

Co-authored-by: Hein Tibosch <[email protected]>

Update litani submodule to version 1.6.0 (#210)

[CBMC] Add assert with readability check (#214)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update proof to use assert with readability check

* Revert ci.yml changes

* Remove unwanted changes

* Null check

* Fix adding NULL checks

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add unit-tests for FreeRTOS_ARP.c (#209)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

* First commit

* Cleanup

* Update: working version

* Coverage of eARPGetCacheEntry

* Update

* Unit-test and clenaup

* 100% line and function coverage

* Uncrustify and update

* 100% all coverage

* Move files to correct location

* Fix tests

* uncrustified

* Update ci.yml

* Update

* uncrustify and update after Hein's comments

* Empty commit

* Clenaup after @yanjos-dev's review

* Update CI

* Cleanup - pass 1

* Remove gdb

* Uncrustify

* Remove litani changes

* Clean up

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

DHCP unit test (#211)

Co-authored-by: Aniruddha Kanhere <[email protected]>

Repair buffer leak when replying to NBNS requests (#215)

* Repair buffer leak when replying to NBNS requests

* Applied Uncrustify

* Variable 'pxNewBuffer' was out of scope

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Static allocation, if configSUPPORT_STATIC_ALLOCATION == 1 (#208) (#217)

* Static allocation of tasks and queues, if configSUPPORT_STATIC_ALLOCATION == 1 (#208)

Is not added to any ported network interfaced.

* Build-check fix

* Uncrustify

* Uncrustify v2

* Update FreeRTOS_IP.c

Co-authored-by: Christian Jensen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Add a method to obtain the handle of the FreeRTOS+TCP IP task (#222)

* Add a method to obtain the handle of the FreeRTOS+TCP IP task

* Added the modified FreeRTOS_IP.c

* Update lexicon.txt

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Code changes for unit-testing (#223)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Make some code changes as a precursor for unit-testing

* remove unused file

* Fixed failing checks

* Fixed CBMC proof

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Use an infinite timeout in FreeRTOS_closesocket when called from a user task (#226)

Reformat MPS2_AN385 network driver (#224)

* Update the MPS2_AN385 network driver so it conforms to the +TCP coding and style guide.

* Update smsc9220_eth_drv.c

Remove #warning message erroneously left in.

Co-authored-by: alfred gedeon <[email protected]>

Uncrustify.

Uncrustify again.

Before sending a challenge ACK, check the sequence number more properly (#225)

* Before sending a challenge ACK, check the sequence number more properly

* Make xSequenceLessThan and xSequenceGreaterThan public functions

* Extended comments on two public functions.

* Fix Spell check

* Although no changes were made to MPS2_AN385, some formatting changes to that driver

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Fix Some warnings

* merge tcp_mem_stats

* Disallow octal IP-addresses

* Uncrustified

* Clear the output variable

* Add unit-tests for pton4

* Uncrustified

* Updated log messages

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
moninom1 pushed a commit that referenced this pull request Sep 14, 2022
* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
author Hein Tibosch <[email protected]> 1609879469 +0800
committer Aniruddha Kanhere <[email protected]> 1619029134 -0700

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Create uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

* Remove unused file

Include ICMP while calculating IP header checksum (#198)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Include ICMP checksum

* Uncrustify

* Update ci.yml

* Spell check

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add comment to CI.yml

fix compiler warnings about casting to format string (#197)

* fix compiler warnings about casting to format string

Fix various warnings like:

/FreeRTOS-Plus-TCP/FreeRTOS_IP.c: In function 'FreeRTOS_strerror_r':
/FreeRTOS-Plus-TCP/FreeRTOS_IP.c:3395:60: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=]
             ( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int32_t ) xErrnum );
                                                           ~^   ~~~~~~~~~~~~~~~~~~~
                                                           %ld

* explicitly cast arguments to format string

This should hopefully make the format string compatible
with all architectures.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Added git-secrets check to Github actions (#201)

Add header file to socket.h so that it can be compiled on its own (#204)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

User hook function for handling unsupported Ethernet frames (#200)

* Adds an optional user hook that gets called for all unhandled Ethernet frames.

* re-wording

* Fix spell check

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Limit the number of attempts to resolve an address in xARPWaitResolution() (#206)

Co-authored-by: Hein Tibosch <[email protected]>

Update litani submodule to version 1.6.0 (#210)

[CBMC] Add assert with readability check (#214)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update proof to use assert with readability check

* Revert ci.yml changes

* Remove unwanted changes

* Null check

* Fix adding NULL checks

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add unit-tests for FreeRTOS_ARP.c (#209)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

* First commit

* Cleanup

* Update: working version

* Coverage of eARPGetCacheEntry

* Update

* Unit-test and clenaup

* 100% line and function coverage

* Uncrustify and update

* 100% all coverage

* Move files to correct location

* Fix tests

* uncrustified

* Update ci.yml

* Update

* uncrustify and update after Hein's comments

* Empty commit

* Clenaup after @yanjos-dev's review

* Update CI

* Cleanup - pass 1

* Remove gdb

* Uncrustify

* Remove litani changes

* Clean up

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

DHCP unit test (#211)

Co-authored-by: Aniruddha Kanhere <[email protected]>

Repair buffer leak when replying to NBNS requests (#215)

* Repair buffer leak when replying to NBNS requests

* Applied Uncrustify

* Variable 'pxNewBuffer' was out of scope

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Static allocation, if configSUPPORT_STATIC_ALLOCATION == 1 (#208) (#217)

* Static allocation of tasks and queues, if configSUPPORT_STATIC_ALLOCATION == 1 (#208)

Is not added to any ported network interfaced.

* Build-check fix

* Uncrustify

* Uncrustify v2

* Update FreeRTOS_IP.c

Co-authored-by: Christian Jensen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Add a method to obtain the handle of the FreeRTOS+TCP IP task (#222)

* Add a method to obtain the handle of the FreeRTOS+TCP IP task

* Added the modified FreeRTOS_IP.c

* Update lexicon.txt

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Code changes for unit-testing (#223)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Make some code changes as a precursor for unit-testing

* remove unused file

* Fixed failing checks

* Fixed CBMC proof

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Use an infinite timeout in FreeRTOS_closesocket when called from a user task (#226)

Reformat MPS2_AN385 network driver (#224)

* Update the MPS2_AN385 network driver so it conforms to the +TCP coding and style guide.

* Update smsc9220_eth_drv.c

Remove #warning message erroneously left in.

Co-authored-by: alfred gedeon <[email protected]>

Uncrustify.

Uncrustify again.

Before sending a challenge ACK, check the sequence number more properly (#225)

* Before sending a challenge ACK, check the sequence number more properly

* Make xSequenceLessThan and xSequenceGreaterThan public functions

* Extended comments on two public functions.

* Fix Spell check

* Although no changes were made to MPS2_AN385, some formatting changes to that driver

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Fix Some warnings

* merge tcp_mem_stats

* remove typo

* Update vSocketWakeupUser Proof

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Cobus van Eeden <[email protected]>
moninom1 pushed a commit that referenced this pull request Sep 14, 2022
* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
author Hein Tibosch <[email protected]> 1609879469 +0800
committer Aniruddha Kanhere <[email protected]> 1619029134 -0700

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

Fix doxygen check (#149)

* Update doxygen version

* update the config file

TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

Create uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

Update uncrustify.yml

* Remove unused file

Include ICMP while calculating IP header checksum (#198)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Include ICMP checksum

* Uncrustify

* Update ci.yml

* Spell check

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add comment to CI.yml

fix compiler warnings about casting to format string (#197)

* fix compiler warnings about casting to format string

Fix various warnings like:

/FreeRTOS-Plus-TCP/FreeRTOS_IP.c: In function 'FreeRTOS_strerror_r':
/FreeRTOS-Plus-TCP/FreeRTOS_IP.c:3395:60: error: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Werror=format=]
             ( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int32_t ) xErrnum );
                                                           ~^   ~~~~~~~~~~~~~~~~~~~
                                                           %ld

* explicitly cast arguments to format string

This should hopefully make the format string compatible
with all architectures.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Added git-secrets check to Github actions (#201)

Add header file to socket.h so that it can be compiled on its own (#204)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

User hook function for handling unsupported Ethernet frames (#200)

* Adds an optional user hook that gets called for all unhandled Ethernet frames.

* re-wording

* Fix spell check

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Limit the number of attempts to resolve an address in xARPWaitResolution() (#206)

Co-authored-by: Hein Tibosch <[email protected]>

Update litani submodule to version 1.6.0 (#210)

[CBMC] Add assert with readability check (#214)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update proof to use assert with readability check

* Revert ci.yml changes

* Remove unwanted changes

* Null check

* Fix adding NULL checks

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Add unit-tests for FreeRTOS_ARP.c (#209)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Add header in the socket file

* Remove unwanted file

* remove unwanted changes

* First commit

* Cleanup

* Update: working version

* Coverage of eARPGetCacheEntry

* Update

* Unit-test and clenaup

* 100% line and function coverage

* Uncrustify and update

* 100% all coverage

* Move files to correct location

* Fix tests

* uncrustified

* Update ci.yml

* Update

* uncrustify and update after Hein's comments

* Empty commit

* Clenaup after @yanjos-dev's review

* Update CI

* Cleanup - pass 1

* Remove gdb

* Uncrustify

* Remove litani changes

* Clean up

* Uncrustify

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

DHCP unit test (#211)

Co-authored-by: Aniruddha Kanhere <[email protected]>

Repair buffer leak when replying to NBNS requests (#215)

* Repair buffer leak when replying to NBNS requests

* Applied Uncrustify

* Variable 'pxNewBuffer' was out of scope

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Static allocation, if configSUPPORT_STATIC_ALLOCATION == 1 (#208) (#217)

* Static allocation of tasks and queues, if configSUPPORT_STATIC_ALLOCATION == 1 (#208)

Is not added to any ported network interfaced.

* Build-check fix

* Uncrustify

* Uncrustify v2

* Update FreeRTOS_IP.c

Co-authored-by: Christian Jensen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Add a method to obtain the handle of the FreeRTOS+TCP IP task (#222)

* Add a method to obtain the handle of the FreeRTOS+TCP IP task

* Added the modified FreeRTOS_IP.c

* Update lexicon.txt

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

Code changes for unit-testing (#223)

* Fix compiler warnings when the TCP Window is not used (#124)

* Fix warnings when TCP window is not used

* Uncrustify

* Move local variables to inner loop in prvNetworkInterfaceInput() (#144)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update litani submodule (#147)

Co-authored-by: Mark R. Tuttle <[email protected]>

* Fix doxygen check (#149)

* Update doxygen version

* update the config file

* TCP_WIN: fix compile warning on x86_64 (#148)

* TCP_WIN: fix compile warning on x86_64

Fix the following warning when building for 64 bit:

warning: conversion from ‘long unsigned int’ to ‘uint32_t’ {aka ‘unsigned int’} changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow]
             uint32_t ulReturn = ~0UL;
                                 ^

* Update FreeRTOS_TCP_WIN.c

Co-authored-by: Aniruddha Kanhere <[email protected]>

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix deprecated volatile compound assignment (#152)

* fixed deprecated volatile compound assignment

C++20 deprecates some undefined or unclear use cases of 'volatile' like
compound assignments and compliant compilers warn about those deprecated
operations.

In vStreamBufferMoveMid the deprecated compound assignment and other
direct accesses to volatile 'StreamBuffer_t->uxMid' is replaced using a
local variable stored back when done.

* Uncrustify

Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* FreeRTOS_ARP.c : store local addresses only (#120)

* FreeRTOS_ARP.c : store local addresses only

* Added the function xARPWaitResolution()

* Added an entry to lexicon.txt.

* Ran Uncrustify

* Update unit test file

* Update

* Declared xARPWaitResolution() in FreeRTOS_IP.h

* Compare the result of xIsCallingFromIPTask() with pdFALSE in stead of 0

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Remove unnecessary #ifndef (#186)

* Add entropy

* remove warning

* Remove unnecessary ifndef

* Remove unwanted changes

* Don't Fragment Flags patch. (#179)

* Moves all IP flag defines in FreeRTOS_IP_Private.h so that they are accessible to all protocols
Adds definitions for the IP fragmentation flags
Modifies the fragmentation check for incoming frames to drop both the first and later fragments.
Sets the "don't fragment" flag for all outgoing IP frames ( ICMP, DNS, UDP, TCP )
Removes ipGET_UDP_PAYLOAD_OFFSET_FOR_FRAGMENT as it appears obsolete. The stack never outputs fragments.

* Uncrustified

* Uncrustify

* Fixes the fragment offset and fragmentation flags masks ( 0x0FFF and 0xF000 -> 0x1FFF and 0xE000 )
Adds a configuration define ( ipconfigADVERTISE_DONT_FRAGMENT_FLAG ) as suggested by htibosch with a default value of zero for backwards compatibility
Updates the comment that explains the discarding of incoming fragments as discussed with Aniruddha Kanhere

* Adds the 'U' qualifier as requested by hs2gh
fixes a typo in FreeRTOSIPConfigDefaults.h

* Shortens the comment in FreeRTOSIPConfigDefaults as per htibosch's suggestion.

* Renames ipconfigADVERTISE_DONT_FRAGMENT to ipconfigFORCE_IP_DONT_FRAGMENT

* same as last commit, simply forgot to save this before pushing.

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* fix IP buffer padding check on 64bit (#146)

* fix IP buffer padding check on 64bit

On 64 bit systems, FreeRTOS_IPInit() would assert
ipconfigBUFFER_PADDING was equal to 14 to "make sure there
is enough space in pucEthernetBuffer to store a pointer."

This prevents the driver from requesting additional
padding, so make the assert greater than or equal to 14.

Also use the final ipBUFFER_PADDING value instead of
ipconfigBUFFER_PADDING, which is probably what was
intended?

* Update after comments

Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update readme.md (#189)

Just fixing the "table of 3 types of STH32H7" so that it renders in github webpage.  I had a tough time reading that table until I looked at the md source.
You could also just put code fences around it:
~~~
/**
 * RAM area	H747	H743	H742	Location
 * ------------------------------------------------
 * DTCM		128k	128k	128k	0x20000000
 * AXI-SRAM	511k	511k	384k	0x24000000
 *
 * SRAM1	128k	128k	32k		0x30000000
 * SRAM2	128k	128k	16k		0x30020000
 * SRAM3	32k		32k	 	-		0x30040000
 * SRAM4	64k		64k		64k		0x38000000
 * Backup   SRAM	4k		4k	4k	0x38800000
 */
~~~

Co-authored-by: Aniruddha Kanhere <[email protected]>

* Update files referencing aws_application_version.h to use iot_application_version.h (#188)

* Update files referencing aws_application_version.h to use iot_application_version.h

* Remove pic32 ethernet _Command_Version function to remove dependency on iot_application_version.h from amazon-freertos repository.

* Remove function defs from header files (#190)

* Add entropy

* remove warning

* Remove function defs from headers

* Some corrections

* More fixes and uncrustify

* Remove the BaseType min function

* Doxygen

* Fix one CBMC proof

* More cbmc proof fixes

* More cbmc fixes

* Some doxygen additions

* Update last CBMC proof

* Doxygen comments

* Doxygen updates

* Doxygen and spell check

* Spell check and unit-test

* Unit test fix

* Update after comments

* Update 2 after comments

* Move function around

* Uncrustify

* Update after comments

Co-authored-by: Gary Wicker <[email protected]>

* Do not release a network buffer if it equals to NULL (#191)

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Circumvent Qemu MPS2 networking bug (#142)

* Add support for MPS2 networking with lan9118/lan9220

* Fix uncrustify errors

* Enable network interrupt handling

* Add network interrupt support to Qemu MPS2 AN385

* Fix function comment

* Fix Uncrustify errors

* Fix Uncrustify errors

* Fix Uncrustify Errors

* Fix typo

* Cirumvent Qemu MPS2 network bug

* Remove commented code, add doxygen comment

* Add a project for static analysis (#195)

* Add entropy

* remove warning

* Remove unwanted changes

* Update tcp_mem_stats.c

* Add Coverity

* Remove unused files

* Add some features

* clean up

* More clean up

* Unwanted additions removal

* Clean up

* Add 32-bit compile option

* Update after comments

* Uncrustify

* Create uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Update uncrustify.yml

* Make some code changes as a precursor for unit-testing

* remove unused file

* Fixed failing checks

* Fixed CBMC proof

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Mark Tuttle <[email protected]>
Co-authored-by: Mark R. Tuttle <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Thomas Pedersen <[email protected]>
Co-authored-by: Hartmut Schaefer <[email protected]>
Co-authored-by: evpopov <[email protected]>
Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: shrewmouse1 <[email protected]>
Co-authored-by: Paul Bartell <[email protected]>
Co-authored-by: Gary Wicker <[email protected]>
Co-authored-by: alfred gedeon <[email protected]>

Use an infinite timeout in FreeRTOS_closesocket when called from a user task (#226)

Reformat MPS2_AN385 network driver (#224)

* Update the MPS2_AN385 network driver so it conforms to the +TCP coding and style guide.

* Update smsc9220_eth_drv.c

Remove #warning message erroneously left in.

Co-authored-by: alfred gedeon <[email protected]>

Uncrustify.

Uncrustify again.

Before sending a challenge ACK, check the sequence number more properly (#225)

* Before sending a challenge ACK, check the sequence number more properly

* Make xSequenceLessThan and xSequenceGreaterThan public functions

* Extended comments on two public functions.

* Fix Spell check

* Although no changes were made to MPS2_AN385, some formatting changes to that driver

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Aniruddha Kanhere <[email protected]>

* Fix Some warnings

* merge tcp_mem_stats

* Add automated uncrustify

* Un-uncrustify

* Uncrustify - manually

* Remove unused comment

* Update user to be github action

* Remove catch_assert from uncrustify

* Add comment to let user know on what to do and run uncrustify a second time

* Return a failure when uncrustify fails

* Add some more info for the user

Co-authored-by: Hein Tibosch <[email protected]>
Co-authored-by: Hein Tibosch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants