FreeRTOS+TCP Zynq: check frame type before calculating ICMP checksum #177
Conversation
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * FreeRTOS V202002.00 | |||
| * FreeRTOS V202007.00 | |||
There was a problem hiding this comment.
I think we should make all the changes at once. I believe that this is not the only instance where the version number is old.
Should we drop this change?
There was a problem hiding this comment.
Shouldn't this have the same version number as the stack? https://github.com/FreeRTOS/FreeRTOS/blob/master/FreeRTOS-Plus/Source/FreeRTOS-Plus-TCP/FreeRTOS_TCP_IP.c#L2
There was a problem hiding this comment.
I just "undid" the version change:
- * FreeRTOS V202002.00
+ * FreeRTOS V202007.00
It is probably better to update all version numbers in a single PR.
…dated later for all portable sources.
|
/bot run checks |
|
Does anyone know why it says that merging is blocked? |
It seems the CBMC checks have failed to report back to github. I am looking into it. |
|
/bot run checks |
1 similar comment
|
/bot run checks |
|
@htibosch, the branch from which this PR was created seems to have disappeared. Due to this the CI cannot fetch the code and hence all the CBMC checks are failing. |
|
I am closing this PR because the branch got lost. The new PR is #304 |
5 participants
Description
This ia a resubmit of my earlier PR #148, which I will close.
Beside the check for the frametype in
xNetworkInterfaceOutput(), it will callvPrintResourceStats()from FreeRTOS_IP.c, in stead of a local functionprvMonitorResources(), which I removed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.