Add Atmel Studio projects for ATMega4809 and AVR128DA48 #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhui-zheng
reviewed
Jul 22, 2020
Contributor
yuhui-zheng
left a comment
yuhui-zheng
left a comment
There was a problem hiding this comment.
Leaving a comment for my next commits.
Besides the type update, I'll also apply the P R#2 from private repo. (Which cover register r28,29,31 in regtest.c as well readme.md update.)
| #define SEMAPHORE_TEST_H | ||
|
|
||
| void vStartSemaphoreTasks( UBaseType_t uxPriority ); | ||
| BaseType_t xAreSemaphoreTasksStillRunning( void ); |
Contributor
There was a problem hiding this comment.
Thank you for fixing this inconsistency.
I may want to update your PR to use BaseType_t in both semtest.{c,h}. Since according to https://www.freertos.org/upgrading-to-FreeRTOS-V8.html, portBASE_TYPE is the old name, and BaseType_t is the new name (since FreeRTOS V8.x.x ).
| } | ||
|
|
||
| /* The controlling and blocking tasks should be in lock step. */ | ||
| if( uxControllingCycles != ( uxBlockingCycles + 1 ) ) |
Contributor
|
Oops... By rebasing, force pushing source branch I accidentally closed the PR and now it won't let me reopen... will figure this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Atmel Studio projects for ATMega4809 and AVR128DA48
Description
Beside the projects there are a couple of changes in Demo/Common files. These changes are:
o (1) In semtest.h I updated the return type of xAreSemaphoreTasksStillRunning function from BaseType_t to portBASE_TYPE because this is the return type it has where it is implemented (semtest.c).
o (2) In recmutex.c I added an explicit cast to UBaseType_t On line 260. I did this because the right-hand expression in the “==” check was, at some point, expected to roll over and therefore be equal to the left-hand side (that was, at that time, 0). Instead, what I think was happening was that the compiler performed integer promotion and turned the 8 bit variable into a 32 bit one, this way roll over did not happened and it was actually comparing 0 to 256 instead of 0 to 255 + 1 (=0 because of roll over).
Test Steps
From what I can tell the above changes should be backwards compatible because: in change (1) the two types actually resolve to the same primitive type and in change (2) the cast actually serves as an additional clarification to the "compiler" about what the code is expected to do.
But you might have a bigger picture than me, and have some more tests to perform in order to confirm the changes are ok, so this is way I described them in detail.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.