Add changes from 2225-2227 amazon-FreeRTOS #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarw13
approved these changes
Jul 13, 2020
aggarw13
reviewed
Jul 13, 2020
Comment on lines
+321
to
+334
| #ifndef ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS | ||
| #define ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS 1 | ||
| #endif | ||
|
|
||
| #ifndef ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS | ||
| #define ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS 0 | ||
| #endif | ||
|
|
||
|
|
||
| #ifndef ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS | ||
| #define ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS 1 | ||
| #endif | ||
|
|
||
| #ifndef ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS |
There was a problem hiding this comment.
Seems like the default definition logic for ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS and ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS macros is repeated
There was a problem hiding this comment.
Also, is there any documentation available for these macros for the customer to understand their utility?
Contributor
There was a problem hiding this comment.
I asked for that in a previous version of this code @aggarw13 but the author's opinion was that they are self-documenting.
aggarw13
approved these changes
Jul 13, 2020
gkwicker
approved these changes
Jul 13, 2020
Comment on lines
+321
to
+334
| #ifndef ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS | ||
| #define ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS 1 | ||
| #endif | ||
|
|
||
| #ifndef ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS | ||
| #define ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS 0 | ||
| #endif | ||
|
|
||
|
|
||
| #ifndef ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS | ||
| #define ipconfigIP_PASS_PACKETS_WITH_IP_OPTIONS 1 | ||
| #endif | ||
|
|
||
| #ifndef ipconfigUDP_PASS_ZERO_CHECKSUM_PACKETS |
Contributor
There was a problem hiding this comment.
I asked for that in a previous version of this code @aggarw13 but the author's opinion was that they are self-documenting.
|
Approved the PR as the files match their equivalent on |
AniruddhaKanhere
added a commit
that referenced
this pull request
Jul 14, 2020
AniruddhaKanhere
added a commit
that referenced
this pull request
Jul 28, 2020
* Fixed Imports for Infineon XMC1100 Board (#88) Co-authored-by: RichardBarry <[email protected]> * FreeRTOS+TCP : add memory statistics and dump packets, v3 (#83) * FreeRTOS+TCP : add memory statistics and dump packets, v3 * Two changes as requested by Aniruddha Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Folder structure change + Fix broken Projects (#103) * Update folder structure * Correct project files * Move test folder * Some changes after Yuki's comments * Add checks in FreeRTOS_Socket.c (#104) * Add fail-safes to FreeRTOS_Socket.c * Use all 'pd' errors * Correction after Hein's comments * Correction after Hein's comments v2 * Changes after Hein's comments * Update after Gary's comments * Add VeriFast kernel queue proofs (#117) * Remove unnecessary semicolon from the linker file (#121) This was creating problem with the onboard LPCLink debug probe. Signed-off-by: Gaurav Aggarwal <[email protected]> * Add Full TCP test suite - not using secure sockets (#131) * Add Full-TCP suite * delete unnecessary files * Change after Joshua's comments * Add changes from 2225-2227 amazon-FreeRTOS (#134) * FreeRTOS+TCP Adding the combined driver for SAM4E and SAME70 v2 (#78) * Adding a combined +TCP driver for SAM4E and SAME70 * Changes after review from Aniruddha Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Aniruddha Kanhere <[email protected]> * Prove buffer lemmas (#124) * Prove buffer lemmas * Update queue proofs to latest kernel source All changes were syntactic due to uncrustify code-formatting * Strengthen prvCopyDataToQueue proof * Add extract script for diff comparison Co-authored-by: Yuhui Zheng <[email protected]> * Sync with +TCP amazon-FreeRTOS (#158) * DNS.c commit * IP.c commit * Add various source & header files * Add Uncrustify file used for Kernel. (#163) * Add Atmel Studio projects for ATMega4809 and AVR128DA48 (#159) * Added explicit cast to allow roll over and avoid integer promotion during cycles counters comparison in recmutex.c. * Fixed type mismatch between declaration and definition of function xAreSemaphoreTasksStillRunning( void ). * Added Atmel Studio demo projects for ATMega4809 and AVR128DA48. * Per https://www.freertos.org/upgrading-to-FreeRTOS-V8.html, I'm updating portBASE_TYPE to BaseType_t. Signed-off-by: Yuhui Zheng <[email protected]> * Update register test for ATmega4809 - to cover r28, r29, r31. - call public API taskYIELD() instead of portYIELD(). * Update ATmega4809 readme.md to include info for serial port setup, and minor wording fix. Co-authored-by: Alexandru Niculae - M17336 <[email protected]> Co-authored-by: S.Burch <[email protected]> Co-authored-by: RichardBarry <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Hein Tibosch <[email protected]> Co-authored-by: Nathan Chong <[email protected]> Co-authored-by: Gaurav-Aggarwal-AWS <[email protected]> Co-authored-by: Yuhui Zheng <[email protected]> Co-authored-by: Carl Lundin <[email protected]> Co-authored-by: Alexandru Niculae - M17336 <[email protected]>
moninom1
pushed a commit
that referenced
this pull request
Sep 14, 2022
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bring in the changes from PRs aws/amazon-freertos#2225, aws/amazon-freertos#2226 and aws/amazon-freertos#2227 to https://github.com/FreeRTOS/FreeRTOS.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.