-
Notifications
You must be signed in to change notification settings - Fork 34
Clang Formatting #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang Formatting #82
Conversation
… to account for this
09f2001 to
63ddcc2
Compare
|
Couple of things:
|
|
Approving because I don't see any stand out problems but I obviously haven't read every single line in depth. |
0369fdb to
f43b2de
Compare
Replaced the files with short ones that are 200 lines long at most.
Do you still feel this way with the current naming convention? |
…e smaller for the tests, minor changes to the action file. Add a README explaining the action and directory layout. Add a git attribute file to keep the line endings as CRLF for needed files
f43b2de to
2bea63a
Compare
… string for inputs
…Also use quiet versions of the actions for use in large repos. This keeps the git log smaller so the page doesn't glitch out trying to show you the results
bb7f54d to
6300f03
Compare
clang-formatting/filesWithTrailingWhitespace/testWithTrailingWhitespace.c
Show resolved
Hide resolved
| uint64_t minutes; | ||
| uint64_t seconds; | ||
| uint64_t msec; | ||
| } DateAndTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entirely a fake C file that is just used to catch formatting errors, any content in the file itself related to code is irrelevant.
| #error "FCLK_FREQUENCY Error: Please enter a valid divider value" | ||
| #endif | ||
|
|
||
| #if( ICLK_FREQUENCY > 100000000L ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entirely a fake C file that is just used to catch formatting errors, any content in the file itself related to code is irrelevant.
Add in a CI-CD action to clang-format files, as well as check for CRLF line endings and trailing whitespace
Add relevant test cases as well.