-
-
Notifications
You must be signed in to change notification settings - Fork 192
Closed
Description
(I don't have any experience with this codebase so maybe these are not bugs.)
} if (unit.isAtLocation(destination)) {
The formatting is strange, the if-statement start on same line as a closing brace, is anelsemissing before theif? If noelseis missing then the if-statement should probably moved to a line of its own.freecol/src/net/sf/freecol/server/ai/ColonyPlan.java
Lines 1054 to 1060 in ef483bd
if (expert != null && u.getUnitChange(UnitChangeType.EXPERIENCE, expert) != null) { score += 10000; } else if (expert != null && u.getUnitChange(UnitChangeType.EXPERIENCE, expert) != null) { score -= 10000; }
The two if-statements have the same condition./ ((tcb.getBottomRightDirtyTile().getX()-tcb.getTopLeftDirtyTile().getX()) * (tcb.getBottomRightDirtyTile().getY()-tcb.getBottomRightDirtyTile().getY()));
Identical expressions (tcb.getBottomRightDirtyTile().getY()) on both sides of subtraction operator.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels