Toponaming: Remove unneeded migration dialog pop-up.#27352
Merged
chennes merged 1 commit intoFreeCAD:mainfrom Feb 9, 2026
Merged
Toponaming: Remove unneeded migration dialog pop-up.#27352chennes merged 1 commit intoFreeCAD:mainfrom
chennes merged 1 commit intoFreeCAD:mainfrom
Conversation
github-actions
bot
added
Mod: Core
Contributor
|
Fixes the issue with CAM. Probably should be backported to v1.1 |
maxwxyz
added
Type: Bug
kadet1090
added
the
Approved: Code Quality
Collaborator
|
@drwho495 do they need to be recomputed again? If so, could this be in the PR? Light or dark theme, save with thumbnail. |
Contributor
I checked on the bitshape files. They're mixed, but where mixed before, and after reviewing other code changes, we're no longer using the thumbnails. So, no big deal. |
Collaborator
|
Ideally the example files which are shown on the start page. |
Contributor
|
Member
|
If we need to recompute the examples we can do that in a new PR. |
4 tasks
Collaborator
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27045
Fixes: #27242
This PR removes the '1.' or '0.' prefix that is added to ElementMapVersion strings to identify if a shape uses a hasher or not. When checking if a shape needs to be migrated or not, we would check to see if that prefix is correct or not, which created these extra migration calls because we do not actually know whether a shape has a hasher or not at this stage of restoration of an FCStd file.
Another thing addressed by this PR is the CAM bit shape files, because they needed to be migrated to use Element Mapping Version 5 instead of 4. They were opened in FreeCAD and migrated to use the new ElementMapVersion formatting described above.