Skip to content

[TD]fix vertex display#27009

Merged
maxwxyz merged 1 commit intoFreeCAD:mainfrom
WandererFan:NoVertsWithFrame_prevtk
Jan 20, 2026
Merged

[TD]fix vertex display#27009
maxwxyz merged 1 commit intoFreeCAD:mainfrom
WandererFan:NoVertsWithFrame_prevtk

Conversation

@WandererFan
Copy link
Contributor

@WandererFan WandererFan commented Jan 18, 2026

This PR fixes an error in PR #26125 as reported here: https://forum.freecad.org/viewtopic.php?p=867617#p867617

Frame and vertex behaviour should now be:

Manual

  • frames and vertices of all views are on or off depending on the "show frames" toggle.
  • vertices (but not frames) are visible if the mouse is in the bounding rectangle of view (mouse over) (a)
  • frames (but not vertices) are visible if a view is selected in the tree (b)

Off

  • frames or vertices are never on

On

  • frames and vertices are always on

Auto

  • frames and vertices are on if
    -- mouse is in the bounding rectangle of view (a)
    -- view is selected
    -- a child of view is selected

(a) Actually, only the "visible" portion of the bounding rectangle if the view stacks below another view.
(b) Vertices will show as soon as the mouse is in the view.

Edit: formatting

@github-actions github-actions bot added the Mod: TechDraw Related to the TechDraw Workbench label Jan 18, 2026
@maxwxyz maxwxyz added Type: Bug This issue or PR is related to a bug backport releases/FreeCAD-1-1 Applied to a PR that is on main to trigger the automatic creation of another PR onto 1.1 labels Jan 18, 2026
@maxwxyz maxwxyz added this to the 1.1 milestone Jan 18, 2026
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Jan 18, 2026
@chennes
Copy link
Member

chennes commented Jan 19, 2026

@ipatch is going to test

@ipatch
Copy link
Contributor

ipatch commented Jan 19, 2026

@WandererFan

forgive me for my lack of techdraw knowledge. i'm under the impression that i'm suppose to be able to toggle frames from the right click menu, no?

image

ie. the dotted orange box?

image

i can't toggle it via the right click menu (context menu) nor from the toolbar.

@WandererFan
Copy link
Contributor Author

Is your preference set to Manual? The toggle function is disabled for Auto, On and Off.

@ipatch
Copy link
Contributor

ipatch commented Jan 20, 2026

Is your preference set to Manual? The toggle function is disabled for Auto, On and Off.

thank you. that was indeed the issue. as you stated above with all the different scenarios concerning the frames / vertices and with the different settings set with the preferences i believe with this PR and i'm getting the results you defined above. 👍️

below are some screenshots i tested after updating my settings to manual.

image image

everything looks good to me, ie. tested and feel free to merge.

@chennes @maxwxyz

@maxwxyz maxwxyz added the Approved: Tested The PR was manually tested and approved label Jan 20, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jan 20, 2026
@maxwxyz maxwxyz merged commit 396d8c5 into FreeCAD:main Jan 20, 2026
17 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Merge Queue Jan 20, 2026
@freecad-ci-runner
Copy link
Collaborator

Backport failed for releases/FreeCAD-1-1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin releases/FreeCAD-1-1
git worktree add -d .worktree/backport-27009-to-releases/FreeCAD-1-1 origin/releases/FreeCAD-1-1
cd .worktree/backport-27009-to-releases/FreeCAD-1-1
git switch --create backport-27009-to-releases/FreeCAD-1-1
git cherry-pick -x 396d8c503d8e1bcce1767cca9fc8a78282cdaea5

@maxwxyz maxwxyz moved this from Done to Approved in Merge Queue Jan 20, 2026
@maxwxyz
Copy link
Collaborator

maxwxyz commented Jan 20, 2026

@WandererFan the backport to 1.1 failed. Are you willing to create a separate PR?

@maxwxyz maxwxyz moved this from Approved to Done in Merge Queue Jan 25, 2026
@maxwxyz maxwxyz moved this from Done to Approved in Merge Queue Jan 25, 2026
@Reqrefusion Reqrefusion moved this from Approved to Done in Merge Queue Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Tested The PR was manually tested and approved backport releases/FreeCAD-1-1 Applied to a PR that is on main to trigger the automatic creation of another PR onto 1.1 Mod: TechDraw Related to the TechDraw Workbench Type: Bug This issue or PR is related to a bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants