Merged
Conversation
2 tasks
Member
|
@ipatch is going to test |
Contributor
Author
|
Is your preference set to Manual? The toggle function is disabled for Auto, On and Off. |
Contributor
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin releases/FreeCAD-1-1
git worktree add -d .worktree/backport-27009-to-releases/FreeCAD-1-1 origin/releases/FreeCAD-1-1
cd .worktree/backport-27009-to-releases/FreeCAD-1-1
git switch --create backport-27009-to-releases/FreeCAD-1-1
git cherry-pick -x 396d8c503d8e1bcce1767cca9fc8a78282cdaea5 |
Collaborator
|
@WandererFan the backport to 1.1 failed. Are you willing to create a separate PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This PR fixes an error in PR #26125 as reported here: https://forum.freecad.org/viewtopic.php?p=867617#p867617
Frame and vertex behaviour should now be:
Manual
Off
On
Auto
-- mouse is in the bounding rectangle of view (a)
-- view is selected
-- a child of view is selected
(a) Actually, only the "visible" portion of the bounding rectangle if the view stacks below another view.
(b) Vertices will show as soon as the mouse is in the view.
Edit: formatting