PartDesign: Apply pattern transform in Feature not VP#26697
Merged
chennes merged 1 commit intoFreeCAD:mainfrom Jan 12, 2026
Merged
PartDesign: Apply pattern transform in Feature not VP#26697chennes merged 1 commit intoFreeCAD:mainfrom
chennes merged 1 commit intoFreeCAD:mainfrom
Conversation
Member
Author
|
@wavexx can you compile and test if it works correctly now? I checked your both files, but you are quite good at finding stuff that I missed 😅 |
kadet1090
added
backport releases/FreeCAD-1-1
maxwxyz
approved these changes
Jan 6, 2026
Collaborator
maxwxyz
left a comment
maxwxyz
left a comment
There was a problem hiding this comment.
It works with the file from the issue
github-actions
bot
added
the
Mod: Part Design
Contributor
|
This fixes the second test case, but breaks again the first sample I posted in issue #26561 |
kadet1090
force-pushed
the
fix-preview-position-2
branch
from
226ac42 to
42744a5
Compare
Member
Author
|
@wavexx Ah I did push older version of the PR, thanks! Should be good now. |
Contributor
|
@kadet1090 I confirm the last version works correctly. Not the best place to ask but.. is there any idea to eventually implement previews for the "part workbench" as well? |
This is followup for FreeCAD#26563 which fixed previews for a given file but broke it for others. This approach should be more robust as it is applied in the Feature itself and not on view provider level which should give us more precise control and per feature transform ability.
maxwxyz
force-pushed
the
fix-preview-position-2
branch
from
ed245fe to
e20e345
Compare
Collaborator
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is followup for #26563 which fixed previews for a given file but broke it for others.
This approach should be more robust as it is applied in the Feature itself and not on view provider level which should give us more precise control and per feature transform ability.
Issues
Before and After Images