Skip to content

Toponaming: Fix recurring migration issue.#26691

Merged
kadet1090 merged 1 commit intoFreeCAD:mainfrom
drwho495:fix-recurring-migration
Jan 6, 2026
Merged

Toponaming: Fix recurring migration issue.#26691
kadet1090 merged 1 commit intoFreeCAD:mainfrom
drwho495:fix-recurring-migration

Conversation

@drwho495
Copy link
Member

@drwho495 drwho495 commented Jan 6, 2026

Fixes: #26690

This change makes the program only mark an object's ElementMapVersion with the "1" prefix if the object has a hasher AND an element map.

Fixes recurring migration bug.
@maxwxyz maxwxyz added this to the 1.1 milestone Jan 6, 2026
@maxwxyz maxwxyz added Type: Bug This issue or PR is related to a bug backport releases/FreeCAD-1-1 Applied to a PR that is on main to trigger the automatic creation of another PR onto 1.1 labels Jan 6, 2026
@maxwxyz maxwxyz moved this from Queue to Merge Meeting in Merge Queue Jan 6, 2026
@kadet1090 kadet1090 enabled auto-merge (rebase) January 6, 2026 10:38
@kadet1090 kadet1090 disabled auto-merge January 6, 2026 10:38
Copy link
Collaborator

@maxwxyz maxwxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@maxwxyz maxwxyz added the Approved: Tested The PR was manually tested and approved label Jan 6, 2026
@maxwxyz maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jan 6, 2026
@kadet1090 kadet1090 enabled auto-merge (squash) January 6, 2026 12:39
@github-actions github-actions bot added the Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Jan 6, 2026
@kadet1090 kadet1090 merged commit 9b64da8 into FreeCAD:main Jan 6, 2026
17 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Merge Queue Jan 6, 2026
freecad-ci-runner pushed a commit that referenced this pull request Jan 7, 2026
This change makes the program only mark an object's ElementMapVersion with the "1" prefix if the object has a hasher AND an element map.

(cherry picked from commit 9b64da8)
@freecad-ci-runner
Copy link
Collaborator

Successfully created backport PR for releases/FreeCAD-1-1:

maxwxyz pushed a commit that referenced this pull request Jan 7, 2026
This change makes the program only mark an object's ElementMapVersion with the "1" prefix if the object has a hasher AND an element map.

(cherry picked from commit 9b64da8)
@PaddleStroke
Copy link
Contributor

After I rebased this morning, my CI is failing because of a arch test. Also all the documents I open prints a warning that is the same as in the arc test failure :
PropertyTopoShape.cpp(503): Recomputation required for document 'FC_site_simple_102' on geo element version change in FC_site_simple_102#Site.Shape: 0.4 -> 0.15.70200.5
Error during tearDown in TestArchSiteGui: Cannot access attribute 'Name' of deleted object
Is this a known issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Tested The PR was manually tested and approved backport releases/FreeCAD-1-1 Applied to a PR that is on main to trigger the automatic creation of another PR onto 1.1 Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Type: Bug This issue or PR is related to a bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Toponaming: Migration dialog gets triggered even after migrating to 1.1.

5 participants