Skip to content

CAM: Waterline OCL Adaptive - Fix Linear and Angular Deflection Values#26422

Merged
sliptonic merged 1 commit intoFreeCAD:mainfrom
Dimitris75:CAM-Fix-Waterline-OCL-Adaptive
Dec 27, 2025
Merged

CAM: Waterline OCL Adaptive - Fix Linear and Angular Deflection Values#26422
sliptonic merged 1 commit intoFreeCAD:mainfrom
Dimitris75:CAM-Fix-Waterline-OCL-Adaptive

Conversation

@Dimitris75
Copy link
Contributor

Fix Lenear and Angular Deflection Values

            LinearDeflection=lin_def,
            AngularDeflection=ang_def,

Issues

Before and After Images

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 23, 2025

Does this need to be backported @Connor9220 ?

@maxwxyz maxwxyz added the Type: Other Tasks, refactoring, quality improvement, actions, dependencies, packaging, translations or other... label Dec 23, 2025
@maxwxyz maxwxyz added this to the 1.2 milestone Dec 23, 2025
@Dimitris75
Copy link
Contributor Author

To fix the following issue. #26414

@Connor9220
Copy link
Contributor

Does this need to be backported @Connor9220 ?

No. This was for a 1.2 Feature.

@luzpaz
Copy link
Contributor

luzpaz commented Dec 24, 2025

@Dimitris75 'Lenear' should be 'Linear', right? Can you fix the commit title too ? (not just the github title but the commit tile, and re-push the commit)

Fix Linear and Angular Deflection Values
@Dimitris75 Dimitris75 force-pushed the CAM-Fix-Waterline-OCL-Adaptive branch from df35086 to 99a4a98 Compare December 24, 2025 22:16
@Dimitris75 Dimitris75 changed the title CAM: Wateline OCL Adaptive - Fix Lenear and Angular Deflection Values CAM: Wateline OCL Adaptive - Fix Linear and Angular Deflection Values Dec 24, 2025
@Dimitris75
Copy link
Contributor Author

@Dimitris75 'Lenear' should be 'Linear', right? Can you fix the commit title too ? (not just the github title but the commit tile, and re-push the commit)

Yes, you're right. I think you are good to go.

@tarman3
Copy link
Contributor

tarman3 commented Dec 25, 2025

Please fix name of the PR
Wateline -> Waterline

@maxwxyz maxwxyz changed the title CAM: Wateline OCL Adaptive - Fix Linear and Angular Deflection Values CAM: Waterline OCL Adaptive - Fix Linear and Angular Deflection Values Dec 25, 2025
Copy link
Contributor

@Connor9220 Connor9220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sliptonic Looks good. Merge it!

@maxwxyz maxwxyz added the Approved: Code Quality The PR was checked for code quality and approved label Dec 26, 2025
@maxwxyz maxwxyz moved this from Queue to Approved in Merge Queue Dec 26, 2025
@sliptonic sliptonic merged commit 83f74f3 into FreeCAD:main Dec 27, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Merge Queue Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved: Code Quality The PR was checked for code quality and approved Mod: CAM Related to the CAM Workbench Type: Other Tasks, refactoring, quality improvement, actions, dependencies, packaging, translations or other...

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

CAM: Merge of 23149 breaks all backward compatibility with 3D Surface ops CAM: Error in merging the New Waterline OCL Adaptive algorithm.

6 participants