CAM: Array - Refactor class PathArray#26324
Merged
sliptonic merged 1 commit intoFreeCAD:mainfrom Dec 27, 2025
Merged
Conversation
maxwxyz
added
the
Type: Other
Contributor
|
@sliptonic Please review. |
Member
|
Refactor looks good. I'm merging. But the refactored functions look very testable. I would encourage some unit tests before going to the next phase. |
Contributor
Author
|
Too early |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No any changes in behavior
Split array patterns by several functions
Note
Step 2 prepare for CAM: Array with multi tool controllers and coolant #23714