BIM: fix deletion of BuildingPart in strict IFC mode#26219
Merged
chennes merged 3 commits intoFreeCAD:mainfrom Dec 22, 2025
Merged
BIM: fix deletion of BuildingPart in strict IFC mode#26219chennes merged 3 commits intoFreeCAD:mainfrom
chennes merged 3 commits intoFreeCAD:mainfrom
Conversation
Add `sg = FreeCADGui.ActiveDocument.ActiveView.getSceneGraph()` to `onDelete`.
Explicitly call `obj.ViewObject.Proxy.attach(obj.ViewObject)`.
In `ifc_vp_buildingpart` call `attach` from `ArchBuildingPart.ViewProviderBuildingPart`.
Roy-043
added
Type: Bug
Roy-043
added
Blocker
github-actions bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
* BIM: fix deletion of BuildingPart in strict IFC mode Add `sg = FreeCADGui.ActiveDocument.ActiveView.getSceneGraph()` to `onDelete`. * BIM: fix deletion of BuildingPart in strict IFC mode Explicitly call `obj.ViewObject.Proxy.attach(obj.ViewObject)`. * BIM: fix deletion of BuildingPart in strict IFC mode In `ifc_vp_buildingpart` call `attach` from `ArchBuildingPart.ViewProviderBuildingPart`. (cherry picked from commit 0af2294)
Contributor
|
Successfully created backport PR for |
chennes
pushed a commit
that referenced
this pull request
Dec 22, 2025
* BIM: fix deletion of BuildingPart in strict IFC mode Add `sg = FreeCADGui.ActiveDocument.ActiveView.getSceneGraph()` to `onDelete`. * BIM: fix deletion of BuildingPart in strict IFC mode Explicitly call `obj.ViewObject.Proxy.attach(obj.ViewObject)`. * BIM: fix deletion of BuildingPart in strict IFC mode In `ifc_vp_buildingpart` call `attach` from `ArchBuildingPart.ViewProviderBuildingPart`. (cherry picked from commit 0af2294)
Roy-043
deleted the
BIM-fix-deletion-of-BuildingPart-in-strict-IFC-mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26191.
In ifc_tools.py we need to explicitly call
obj.ViewObject.Proxy.attach(obj.ViewObject)inadd_object. This is probably because the ViewObject of the BuildingPart has already been attached, we are replacing/updating it.Additionally:
ifc_vp_buildingpartwrongly used theattachfunction fromifc_vp_object.onDeletein ArchBuildingPart.py did not definesg.