SVG export: improve performance#26149
Merged
Roy-043 merged 2 commits intoFreeCAD:mainfrom Dec 20, 2025
Merged
Conversation
Lookup in edge list becomes O(1), significantly improving SVG export speed
2 tasks
maxwxyz
added
Type: Other
Contributor
|
Thanks for contributing to FreeCAD. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2025
* SVG export: use a set to match edges instead of a list Lookup in edge list becomes O(1), significantly improving SVG export speed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit cead907)
Contributor
|
Successfully created backport PR for |
maxwxyz
pushed a commit
that referenced
this pull request
Dec 21, 2025
* SVG export: use a set to match edges instead of a list Lookup in edge list becomes O(1), significantly improving SVG export speed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit cead907)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During SVG export, most of the time is spent matching edges, creating a O(N^2) loop that significantly impacts performance.
Using a set instead of a list, lookup in edge list becomes O(1), improving SVG export speed.
get_edge_descriptoris equivalent to the match test done byDraftGeomUtils.findEdge, but O(1). Logic is unchanged.Issues
Fixes #22327 #13249
Before and After Images
Exporting the file in #13249 takes a matter of seconds instead of "2 hours".