Gui: Use largest possible marker if needed#26136
Merged
chennes merged 1 commit intoFreeCAD:mainfrom Dec 13, 2025
Merged
Conversation
This is a quick and dirty fix for FreeCAD#22010 Basically if we want to use a bigger marker size than available, we use the biggest one available. This is not a good way to fix the issue - we should ensure that the marker size that the user requests is actually available - this, however, requires more significant changes to the code.
Contributor
|
I think this still needs to be backported. I have added the labels. Not sure if it will work though. |
Collaborator
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick and dirty fix for #22010
Basically if we want to use a bigger marker size than available, we use the biggest one available. This is not a good way to fix the issue - we should ensure that the marker size that the user requests is actually available - this, however, requires more significant changes to the code.
Issues
Before and After Images