CMake: require Netgen when BUILD_FEM_NETGEN is ON, don't fail silently#25990
Merged
chennes merged 2 commits intoFreeCAD:mainfrom Feb 3, 2026
Merged
CMake: require Netgen when BUILD_FEM_NETGEN is ON, don't fail silently#25990chennes merged 2 commits intoFreeCAD:mainfrom
chennes merged 2 commits intoFreeCAD:mainfrom
Conversation
github-actions
bot
added
the
Packaging/building
maxwxyz
added
the
Type: Other
Contributor
Author
|
CI was not happy, because when using external smesh, we were still calling |
maxwxyz
force-pushed
the
find-netgen-fix
branch
from
4d3e1f4 to
193a789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
BUILD_FEM_NETGENisONand Netgen could not be found, CMake generation would still happen and caused build errors later on. Usingfind_package_handle_standard_argsfixes this behavior.