added a copy button which copies all the errors and traceback to clip… by Mr-Rahul-Paul · Pull Request #25979 · FreeCAD/FreeCAD

Mr-Rahul-Paul · 2025-12-05T22:05:43Z

This PR fixes #25599 by adding a "Copy" button to the Unit Test dialog, allowing users to copy the details of failing tests directly to the clipboard.

Before

No easy way to extract the list of Errors from the UI.

After

A new "Copy" button is added below the Close button. On clicking, it copies errors and traceback(s) to the system clipboard.

How I reproduced the Issue

Open the demo file AssemblyExample.FCStd.
Enable the Test Framework workbench from Preferences.
Run Self-test → TestApp.All.
Click Start and wait for failures to appear in the list.

Changes done

Added "Copy" button in UnitTest.ui file with name "copyButton"
Declared onCopyButtonClicked() function in UnitTestImp.h
clicking 'copybutton' calls 'onCopyButtonClicked()' which copies the error(s) to clipboard

Remarks

the logic used in onCopyButtonClicked() is that function iterates through the list of failures (treeViewFailure), extracting both the error names and the tracebacks, appending them to a string variable which is then copied to the clipboard.
I have tried my best to ensure all new function names (like onCopyButtonClicked) and variable naming conventions follow the existing patterns to maintain consistency

xtemp09 · 2025-12-06T11:20:11Z

Is there a reason to create a MessageBox to show that everything is copied? Would it be better to change the title temporarily, like it is done in the About dialog? The same goes to the case if the text is empty. If there is nothing to copy, why bother to show a MessageBox?

Why is double "\n" added? Is it more beneficial than one?

Is the Copy button suitable to be near the Close button? I think that it is ought to be far to avoid accidental activation.

xtemp09 · 2025-12-06T11:26:00Z

<string>&amp;Copy </string>

I think that the ampersand before C must be removed, since it is present in the Close button's text.

Why does this string end with space?

luzpaz · 2025-12-06T11:36:48Z

Thanks for addressing this long standing issue (it existed before #25599 was opened)

Mr-Rahul-Paul · 2025-12-06T12:00:33Z

Hey @xtemp09

Is there a reason to create a MessageBox to show that everything is copied? Would it be better to change the title temporarily, as it is done in the About dialog? The same goes to the case if the text is empty. If there is nothing to copy, why bother to show a MessageBox?

I am also a freelance 3d artist. So I based it on Blender's behaviour. In Blender, there is often a box that pops up in the bottom when some certain tasks are performed, so I thought adding a pop-up to notify would be a good idea. (this can be changed if the maintainers don't like it.)

eg (blender screenshot):

Why is double "\n" added? Is it more beneficial than one?

I noticed this pattern elsewhere in the codebase
msg += "\n\n";
So I kept it consistent. Happy to change to single \n if preferred.

I think that the ampersand before C must be removed, since it is present in the Close button's text.

I tried to match the pattern of the code in the file UnitTesImp.cpp (so as not to make a mess and keep the code structure consistent)

Why does this string end with space?

Agreed, that should be removed.

xtemp09 · 2025-12-06T12:37:20Z

I think that the ampersand before C must be removed, since it is present in the Close button's text.

I tried to match the pattern of the code in the file UnitTesImp.cpp (so as not to make a mess and keep the code structure consistent)

Usage of amersand creates a mnemonic shortcut.¹ Perhaps, the ampersand in the "&Close" button must be removed, for consistency.

I am also a freelance 3d artist. So I based it on Blender's behaviour. In Blender, there is often a box that pops up in the bottom when some certain tasks are performed, so I thought adding a pop-up to notify would be a good idea. (this can be changed if the maintainers don't like it.)

I think that a pop-up notification is the best option along with a message in the status bar. =) But, the About dialog already has a button to copy to clipboard. I think it would be beneficial to mimic its behavior.

I think also that placing the Copy button next to the Close button is not a good idea. In my opinion, they should be separated with a separator or placed in different locations.

https://doc.qt.io/archives/qt-5.15/qshortcut.html#details ↩

Mr-Rahul-Paul · 2025-12-06T17:17:57Z

Removed ampersand from 'Close'
removed space from copy button
after copying the Errors , the message shows up in the status bar (below the error tree) instead of a popup
removed an unwanted header
moved copy button on top of Help button

awaiting feedback from maintainers

xtemp09 · 2025-12-06T20:08:12Z

It appears the tab order needs to be adjusted.

chennes · 2025-12-07T00:49:11Z

Thanks for the PR, @Mr-Rahul-Paul (and thanks @xtemp09 for the quick review). @FreeCAD/design-working-group any opinion on this button layout?

Mr-Rahul-Paul · 2025-12-15T20:22:19Z

To keep things clear this is what the UI look like after the review and changes

Mr-Rahul-Paul · 2025-12-17T17:26:40Z

@chennes any feed-back from you is appreciated

…board

for more information, see https://pre-commit.ci

chennes

I've made a couple of changes

chennes · 2026-01-12T03:06:12Z

src/Mod/Test/Gui/UnitTestImp.cpp

+    QString text;
+    QTreeWidgetItemIterator it(ui->treeViewFailure);
+    while (*it) {
+        text += (*it)->data(0, Qt::UserRole).toString() + "\n\n";


Suggested change

text += (*it)->data(0, Qt::UserRole).toString() + "\n\n";

text += (*it)->data(0, Qt::UserRole).toString() + QStringLiteral("\n\n");

chennes · 2026-01-12T03:11:20Z

src/Mod/Test/Gui/UnitTest.ui

  <tabstop>helpButton</tabstop>
  <tabstop>aboutButton</tabstop>
  <tabstop>closeButton</tabstop>
+  <tabstop>copyButton</tabstop>


This should now be above the help button.

github-project-automation bot added this to Merge Queue Dec 5, 2025

github-project-automation bot moved this to Queue in Merge Queue Dec 5, 2025

github-actions bot added the Mod: Test Related to the Test Workbench label Dec 5, 2025

Mr-Rahul-Paul force-pushed the bug/25599/test-copy-failing-list branch 2 times, most recently from 21117df to 108cc1c Compare December 6, 2025 06:45

maxwxyz added this to the 1.2 milestone Dec 6, 2025

maxwxyz moved this from Queue to Merge Meeting in Merge Queue Dec 6, 2025

maxwxyz added the Type: Feature FR for improvements or new features label Dec 6, 2025

Mr-Rahul-Paul force-pushed the bug/25599/test-copy-failing-list branch 2 times, most recently from b19baba to 7a5168a Compare December 6, 2025 17:13

maxwxyz moved this from Merge Meeting to Approved in Merge Queue Jan 5, 2026

chennes self-assigned this Jan 5, 2026

maxwxyz force-pushed the bug/25599/test-copy-failing-list branch from 0f72e87 to 10c4de1 Compare January 8, 2026 17:47

Mr-Rahul-Paul added 4 commits January 11, 2026 20:59

added a copy button which copies all the errors and traceback to clip…

c0f7dec

…board

removed unused variable

942a86e

removed space at end of Copy string

2be5875

copied text notification in status bar

e9e9b88

Mr-Rahul-Paul and others added 3 commits January 11, 2026 20:59

removed unwanted header

4e1a781

[pre-commit.ci] auto fixes from pre-commit.com hooks

d36f681

for more information, see https://pre-commit.ci

Test: Address review comments

4b521ef

chennes force-pushed the bug/25599/test-copy-failing-list branch from 10c4de1 to 4b521ef Compare January 12, 2026 03:32

chennes approved these changes Jan 12, 2026

View reviewed changes

chennes enabled auto-merge (squash) January 12, 2026 03:33

chennes disabled auto-merge January 12, 2026 03:33

chennes enabled auto-merge (squash) January 12, 2026 03:34

chennes merged commit a628391 into FreeCAD:main Jan 12, 2026
12 checks passed

github-project-automation bot moved this from Approved to Done in Merge Queue Jan 12, 2026

	text += (*it)->data(0, Qt::UserRole).toString() + "\n\n";
	text += (*it)->data(0, Qt::UserRole).toString() + QStringLiteral("\n\n");

Uh oh!

Conversation

Mr-Rahul-Paul commented Dec 5, 2025

Before

After

How I reproduced the Issue

Changes done

Remarks

Uh oh!

xtemp09 commented Dec 6, 2025

Uh oh!

xtemp09 commented Dec 6, 2025

Uh oh!

luzpaz commented Dec 6, 2025

Uh oh!

Mr-Rahul-Paul commented Dec 6, 2025

Uh oh!

xtemp09 commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

Mr-Rahul-Paul commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xtemp09 commented Dec 6, 2025

Uh oh!

chennes commented Dec 7, 2025

Uh oh!

Mr-Rahul-Paul commented Dec 15, 2025

Uh oh!

Mr-Rahul-Paul commented Dec 17, 2025

Uh oh!

chennes left a comment

Choose a reason for hiding this comment

Uh oh!

chennes Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

chennes Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xtemp09 commented Dec 6, 2025 •

edited

Loading

Mr-Rahul-Paul commented Dec 6, 2025 •

edited

Loading