[ArchWall] Fix: Better Info 0 Width Or 0 Height#25878
Merged
Roy-043 merged 11 commits intoFreeCAD:mainfrom Jan 14, 2026
Merged
Conversation
maxwxyz
added
the
Type: Other
furgo16
suggested changes
Dec 27, 2025
Update - Following discussion at FreeCAD#25878 Fix FreeCAD#25338
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Update - Following discussion at FreeCAD#25878 Update 2 - Add translation Fix FreeCAD#25338
Contributor
Author
|
Translation added |
Contributor
|
For a wall that relies on additions for its shape, a superfluous warning can now appear after every recompute. That needs some more thought. I would also like a simpler text message. Why not just?: |
Update - Following discussion at FreeCAD#25878 Update 2 - Add translation Update 3 - Follow comment on FreeCAD#25878 (comment) - Test of shape further relocated to after self.applyShape() Fix FreeCAD#25338
tritao
pushed a commit
to tritao/FreeCAD
that referenced
this pull request
Jan 17, 2026
* [ArchWall] Fix: Better Info 0 Width Or 0 Height Fix FreeCAD#25338 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ArchWall] (Update) Fix: Better Info 0 Width Or 0 Height Update - Following discussion at FreeCAD#25878 Fix FreeCAD#25338 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ArchWall] (Update 2) Fix: Better Info 0 Width Or 0 Height Update - Following discussion at FreeCAD#25878 Update 2 - Add translation Fix FreeCAD#25338 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [ArchWall] (Update 3) Fix: Better Info 0 Width Or 0 Height Update - Following discussion at FreeCAD#25878 Update 2 - Add translation Update 3 - Follow comment on FreeCAD#25878 (comment) - Test of shape further relocated to after self.applyShape() Fix FreeCAD#25338 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Improve warning message for ArchWall object --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Roy-043 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25338
Issues
Before and After Images