SPDX [ 40 ][ Src / Mod / Robot ]#25115
Conversation
maxwxyz
added
the
Type: Other
| @@ -1,3 +1,5 @@ | |||
| // SPDX-License-Identifier: LGPL-2.1-or-later | |||
There was a problem hiding this comment.
Considering the license history of the Robot workbench, I took a closer look at this one. I believe that it comes from here: https://github.com/orocos/orocos_kinematics_dynamics/blob/fb840b0edb3e9905c354276d6513dddf4fd4ac1b/orocos_kdl/src/frameacc.inl -- so I can confirm that LGPL-2.1 is correct.
|
It's not obvious to a casual inspection that the entire kdl_cp subdirectory is really a 3rd party library -- it's been totally separated from its provenance. For future work we should consider adding some kind of acknowledgement and backlink. Or maybe someone like @onekk would like to take on making it a subtree? |
|
From the little I know the kdl library was patched by jregel (I have read this info in one of the old posts, but I don't remember where). So it is not an exact copy of the upstream, that in the meantime has evolved a lot. I don't code in C++ as my knowledge is very limited to the minimum to read some not too complicated sources. as the kdl is the core of the inverse kinematics probably some quite deep knowledge of the matter is needed to think to update the sources to a more recent upstream code. kind regards |
maxwxyz
added
backport releases/FreeCAD-1-1
4 participants
Added missing SPDX license identifiers.