PR has a conflict

Great thanks

However I think checking just the subobject is not ideal.
If I understand the code correctly, then now if you have :

Part (not selectable)

• Box (selectable)

Then the box is selectable. No?

Then it is not good. If the parent container is set as not selectable then the child should also be not selectable.

Selectable should be acting like the Visibility property :
Objects within a container should be selectable only if his parents are recursively selectable.

So I think the solution is rather to keep the topParent->isSelectable() function.
And override App::Part (or maybe OriginGroupExtension) ::isSelectable such that it checkes child objects

something like :

App::Part::isSelectable(subname)
{
    if (!this->isSelectable){
         return false;
    }
    childObj = this->getDocument()->getObject(subName.split[0])
    return childObj->isSelectable();
}

Maybe it's worth checking how Visibility is doing it and just copying the same behavior

Actually I just checked and in current main FreeCAD, App::Part do not have Selectable Property. Only in Realthunder's branch there is.

Yet again a feature that got lost in Linkstage and never got merged...

Additionally I have just tested in more details and found that :

Part

• Box (Not selectable)
  Works OK.

Body (selectable)

• Pad (Not selectable)
  OK

Body (Not selectable)

• Pad (Not selectable)
  OK

Part

• Body (Not selectable)
• • Pad (selectable)
    NOT OK

Part

• Body (selectable)
• • Pad (Not selectable)
    OK

So what we learn here is that what is actually broken here is the Body's Selectable property.
It override the Tip's Selectable property only if body is the root object.

My guess is that all of this works properly in LinkStage. @realthunder

@PaddleStroke thanks for catching this and sorry for late reply, been busy last month. Could you recheck it? I decided to not port RT for now as I will be probably refactoring those parts of the code so I left area for improvement. I've just added a simple parents check for the currently selected object, so it will reject selection if parent is not selectable.

Sounds good I think. Although I have never used getSubObjectList before so I'm not sure how it behaves, but if it behaves as I think it should then it's a convenient helper that I just learned about.

Then we can also add a Selectable property to App::Part and override App::Part::isSelectable and it should all work with your current code I think.

@PaddleStroke I've implemented this in a separate commit by changing ViewProviderPart to inherit from ViewProviderGeometryObject (instead of ViewProviderDragger).

This adds the property to Part containers, since it is inherited from ViewProviderGeometryObject, and also gives the override of isSelectable() as it is already implemented in ViewProviderGeometryObject class. But you can double check.

I've implemented this in a separate commit by changing ViewProviderPart to inherit from ViewProviderGeometryObject (instead of ViewProviderDragger).

Oh wait I am already doing that in a PR : https://github.com/FreeCAD/FreeCAD/pull/26174/files#diff-afbda03a6d43c61b6d039dbc3e361c32f8481082209088e133135c40fda1ce5b

Although the conflict is quite minimal so it's no matter.

@PaddleStroke Hmm.. want me to adapt or will you adapt the PR?

You can leave it, it'll be a small conflict no problem.

@PaddleStroke so, is the patch alright? Can we merge this soon?

It looks good to me.