Cam simulator feature update#15597
Conversation
|
@chennes , I took a look at the Clang-Tidy report and there are like a gazilion warnings. How do I know which are important? shai |
|
For some reason all builds are failing on topological naming tests |
The only ones you should be addressing are in the code touched by this PR, not anywhere else in the code. I don't see that many of them. I can probably get you a fixup commit tomorrow evening if you'd like. Regarding the CI, a previous commit broke the helix algorithm. If you rebase now the issue should be resolved. |
I'm probably doing something wrong when I analyze the lint results as I don't see any way to separate the warnings on the code changes from the entire list of warnings. If you can make a fixup commit that would be great. shai |
|
@chennes , Thanks! |
|
More incoming tomorrow I hope. |
|
This feature update fixes a bug which causes FreeCAD to crash without any warning. So from a CAM/PATH user perspective it would be great if this update could be merged before the 1.0 release. |
|
This is deemed good to merge but needs rebasing |
|
Hi @sliptonic |
The branch has 36 commits. A lot of those are just merges from main. Can the entire PR be squashed down to 1 commit? If so, I think I can merge it directly. If you want to preserve any commits, I think you should do an interactive rebase and remove the noise. |
|
I will try to make it a single commit. I can hold the history in a separate branch. |
Merging it automatically into one commit is easy. I can do that automatically from Github. It's only if you want to preserve intermediate commits in the shared history. |
|
Oh! that would be great... I just started a tedious process to do it manually by copying files... |
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
* remove redundant code * Improve lighting, add ambient occlusion * Add cleanup code. Dialog is now deleted when cloesd. * change back to ambient occlusion * Fix G8x drill sequence bug. issue FreeCAD#14369 * fix bad simulation artifacts under Linux and QT. Issue FreeCAD#14369 * fix merge issue * fix border artifact on buttons * support showing path lines. revise the gui. * add option for arbitrary solids. wip * use vectors instead of mallocs * Handle arbitrary stock shapes + show base shape. * Complete the base shape display feature. eliminate co-planar artifacts. * support window scaling. upstream issue FreeCAD#14334 * Apply lint fixes * some missing lints. * Attend pylint issues * Apply code fixes based on @kadet1090 review * fix some clang-tidy warnings. * CAM: Linter cleanup round 1 --------- Co-authored-by: Chris Hennes <[email protected]>
8 participants
Hi all
This is a questionable PR and I need feedback (@sliptonic please also comment)
I got this info from one of the users: https://forum.freecad.org/viewtopic.php?p=772512#p772512
it seems that not only the simulator can not handle the simulation (blank screen) it can also crash freecad.
Testing it in my latest simulator update, his file worked flawlessly and of course without any crashes.
The latest update indeed treats window handling differently and much more stable. However it also contains many more features that are missing in the merged version.
I can try to pick the necessary minimum fixes needed, but though it will prevent freecad from crashing, it will probably still not work on his file.
I believe we should update the simulator completely. It will be much more suitable for a 1.0 version. Apart from the new features, there are many fundamental changes that contribute to stability.
And again - the old simulator is still there - so if there are any issues we can just not use the new one.
This version also fixes several pending issues.
shai