Skip to content

Change PartDesign Pad and Revolution tree icons#14074

Merged
chennes merged 6 commits intoFreeCAD:mainfrom
NomAnor:pd-icons
May 20, 2024
Merged

Change PartDesign Pad and Revolution tree icons#14074
chennes merged 6 commits intoFreeCAD:mainfrom
NomAnor:pd-icons

Conversation

@NomAnor
Copy link
Contributor

@NomAnor NomAnor commented May 17, 2024

Use the same icons as the toolbar buttons.

Fixes #14066.

Use the same icons as the toolbar buttons.
@github-actions github-actions bot added the Mod: Part Design Related to the Part Design Workbench label May 17, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 17, 2024

I would hold back on this until we have consensus as this was done intentionally at some point, also in other workbenches.

@NomAnor NomAnor marked this pull request as draft May 17, 2024 13:14
@NomAnor NomAnor marked this pull request as ready for review May 19, 2024 10:26
@NomAnor
Copy link
Contributor Author

NomAnor commented May 19, 2024

I updated the icons based on the comments in #14066. I commented some screenshots.
@Reqrefusion provided some recolored versions of the icons.

  • Some unused icons are removed
  • All PartDesign features use the same icons for the toolbar and the tree
  • All Part icons use a blue theme and the primitives use the same icon for the toolbar and the tree
  • The task suggestions use the blue Part_Box icon in their header

@chennes chennes merged commit 74db404 into FreeCAD:main May 20, 2024
@FEA-eng
Copy link
Contributor

FEA-eng commented May 22, 2024

For me, the Shapebuilder icon is still yellow. Is it normal?

icon

OS: Windows 10 build 19045
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37436 (Git)
Build type: Release
Branch: main
Hash: 040502280fc9637fb3aada037523283168b81a02
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Polish/Poland (pl_PL)

@NomAnor
Copy link
Contributor Author

NomAnor commented May 23, 2024

Here too, its a problem with the BIM Workbench which has a copy of the yellow icon, but with the same name. I'll file an issue.

@NomAnor NomAnor mentioned this pull request May 23, 2024
2 tasks
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 23, 2024

@NomAnor NomAnor deleted the pd-icons branch May 26, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Part Design Related to the Part Design Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong tree icons for PD Pad and Revolution

4 participants