Skip to content

Draft: Draft_SetStyle new Material handling#13914

Merged
chennes merged 2 commits intoFreeCAD:mainfrom
Roy-043:Draft-Draft_SetStyle-new-Material-handling
May 13, 2024
Merged

Draft: Draft_SetStyle new Material handling#13914
chennes merged 2 commits intoFreeCAD:mainfrom
Roy-043:Draft-Draft_SetStyle-new-Material-handling

Conversation

@Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented May 9, 2024

Discussion: #13657.

To accommodate the new properties the task panel now has a tabbed interface. The properties on the Annotation tab have been reordered to match the related Preference page.

The order of the Shape appearance properties matches the related Preference page as well. I do not understand why these properties have have different order in the Properties view (if you expand the ShapeAppearance node). @davesrocketshop Do you know the reason for this?

Draft_SetStyle_Taskpanel_Tab_Shape Draft_SetStyle_Taskpanel_Tab_Annotation

@github-actions github-actions bot added the Mod: Draft Related to the Draft Workbench label May 9, 2024
@davesrocketshop
Copy link
Contributor

The order of the Shape appearance properties matches the related Preference page as well. I do not understand why these properties have have different order in the Properties view (if you expand the ShapeAppearance node). @davesrocketshop Do you know the reason for this?

The short answer is no, I don't, but I'll look into it. The property editor was modified by @wwmayer so he may know.

@wwmayer
Copy link
Contributor

wwmayer commented May 9, 2024

I guess the order of the colors is the same as of the documentation of the SoMaterial class: https://www.coin3d.org/Coin/html/classSoMaterial.html
But I don't mind if the order of specular and emissive color should be swapped.

Also removed the ret_default argument.
@yorikvanhavre
Copy link
Member

LGTM!

@chennes chennes merged commit fef3a24 into FreeCAD:main May 13, 2024
@Roy-043 Roy-043 deleted the Draft-Draft_SetStyle-new-Material-handling branch May 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Draft Related to the Draft Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants