Skip to content

Fem: Remove unused view properties#13569

Merged
chennes merged 1 commit intoFreeCAD:mainfrom
marioalexis84:fem-remove_view_prop
Apr 29, 2024
Merged

Fem: Remove unused view properties#13569
chennes merged 1 commit intoFreeCAD:mainfrom
marioalexis84:fem-remove_view_prop

Conversation

@marioalexis84
Copy link
Member

To be merged after #13274.
Removes unused constraint symbol view properties.
Now the color of the symbol is controlled by the ShapeAppearance property.

@github-actions github-actions bot added the Mod: FEM Related to the FEM Workbench label Apr 21, 2024
@marioalexis84
Copy link
Member Author

@wwmayer Is it planned to remove the Transparency property from Gui::ViewProviderGeometryObject?

@wwmayer
Copy link
Contributor

wwmayer commented Apr 22, 2024

Is it planned to remove the Transparency property from Gui::ViewProviderGeometryObject?

That's a good question! Removing it would simplify quite a few things in the code but I am not sure if people like it to have the transparency as a child item of the Shape Appearance item.

The ideal solution would be to make the Transparency item a sibling item of the Shape Appearance item.

@marioalexis84 marioalexis84 marked this pull request as draft April 22, 2024 14:09
@marioalexis84 marioalexis84 marked this pull request as ready for review April 23, 2024 03:13
@marioalexis84 marioalexis84 requested a review from wwmayer April 23, 2024 16:10
@yorikvanhavre
Copy link
Member

@davesrocketshop could you summarize somewhere what would be needed for other workbenches to port to the new Material system?

@chennes chennes merged commit 5d69945 into FreeCAD:main Apr 29, 2024
@davesrocketshop
Copy link
Contributor

@davesrocketshop could you summarize somewhere what would be needed for other workbenches to port to the new Material system?

Starting a thread. There's a lot of stuff to cover so I'll add a post at a time

@davesrocketshop
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: FEM Related to the FEM Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants