Skip to content

Sketcher: Trim tool, hold click and move. Fixes #6152#13188

Merged
yorikvanhavre merged 1 commit intoFreeCAD:mainfrom
Ondsel-Development:sk_trim_power
Apr 15, 2024
Merged

Sketcher: Trim tool, hold click and move. Fixes #6152#13188
yorikvanhavre merged 1 commit intoFreeCAD:mainfrom
Ondsel-Development:sk_trim_power

Conversation

@PaddleStroke
Copy link
Contributor

Sketcher: Trim tool, hold click and move. Fixes #6152

2024-03-28.11-04-45.mp4

@github-actions github-actions bot added the Mod: Sketcher Related to the Sketcher Workbench label Mar 28, 2024
@PaddleStroke PaddleStroke marked this pull request as draft March 28, 2024 14:11
@prokoudine
Copy link
Contributor

The new behavior is vulnerable to fast movements. You need to move the mouse pointer slowly, otherwise the tool will skip some lines on its way. Sometimes those skipped lines would be in the middle and sometimes it would be the last line it crosses.

vokoscreenNG-2024-03-29_14-55-30.mp4

@PaddleStroke
Copy link
Contributor Author

Yes there's not much way around this, it's because mouseMove triggers only so often. So if mouse goes too fast it won't catch all

@FEA-eng
Copy link
Contributor

FEA-eng commented Apr 1, 2024

I tested this, works really well. It's a handy feature. @PaddleStroke Can you undraft it if it's ready?

@PaddleStroke PaddleStroke marked this pull request as ready for review April 9, 2024 13:53
@yorikvanhavre yorikvanhavre merged commit 4b968a6 into FreeCAD:main Apr 15, 2024
@PaddleStroke PaddleStroke deleted the sk_trim_power branch May 2, 2024 16:10
@Hetman506
Copy link

Hetman506 commented Sep 13, 2024

Hello.
What if this tool instead of trimming edges directly (in continuous mode) would draw polyline, and then edges which cross this polyline would be trimmed?
It can solve mouseMove triggering problem.

@PaddleStroke
Copy link
Contributor Author

Hi and thanks for your suggestion.
I see what you're suggesting. It's how it works in fusion if I recall correctly.
Drawing a line is not a problem. The problem is more how do you know which edge is crossed. And it needs quite a rework of the tool. While this PR was simpler to do as it was modifying the current tool only a little bit. Making as you suggest is a much larger work that I can't do right now.
But if someone wants a project to tackle, feel free to grab this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Sketcher Related to the Sketcher Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sketcher: Add new method for trim sketch

5 participants