Skip to content

FEM Netgen Min. Size#12794

Merged
chennes merged 5 commits intoFreeCAD:mainfrom
FEA-eng:netgen_min_size
Apr 19, 2024
Merged

FEM Netgen Min. Size#12794
chennes merged 5 commits intoFreeCAD:mainfrom
FEA-eng:netgen_min_size

Conversation

@FEA-eng
Copy link
Contributor

@FEA-eng FEA-eng commented Mar 6, 2024

fixes #12716

@marioalexis84 Can you test this later? It looks ok on Ubuntu but there are known issues when compiling with Netgen (not only on my side) so it would be good if you could confirm that it works properly - actually affects the mesh.

Perhaps someone could also compile on Windows? It seems that Netgen works much better there and maybe doesn't cause those compilation issues (btw. I wonder if they are fixable).

@github-actions github-actions bot added the Mod: FEM Related to the FEM Workbench label Mar 6, 2024
@marioalexis84
Copy link
Member

The last time I tried I had compilation problems with Netgen. I'll try again.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Mar 7, 2024

The last time I tried I had compilation problems with Netgen. I'll try again.

Thanks. I'm afraid those issues are persistent but it would be good to finally get rid of them, if possible. Werner's reply doesn't fill me with optimism though. Fortunately, Netgen works very well on Windows. Perhaps I should create another GitHub issue about those problems on Ubuntu but if they are as deep as they appear to be then it might be better to leave them for now so that we don't waste our time on this and focus on other FEM issues instead.

@yorikvanhavre
Copy link
Member

@marioalexis84 can you look again?

@marioalexis84
Copy link
Member

The new property is added correctly and the task dialog is fine too.
Unfortunately I can't test the mesher properly as it crashes when the object is executed.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Mar 26, 2024

Unfortunately I can't test the mesher properly as it crashes when the object is executed.

Yeah, I had the same and user1234 confirmed that it happens even without those changes: https://forum.freecad.org/viewtopic.php?t=85829#p744851

It would be great if someone could check this on Windows.

@chennes chennes self-requested a review April 1, 2024 15:47
Copy link
Member

@chennes chennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Windows today and it appears to work -- at least, I got no errors, and when I changed the minSize the number of cells in the mesh changed. Is that evidence enough that it is working properly?

@marioalexis84
Copy link
Member

Should be enough. Once in main, @FEA-eng can also test on Windows.

@chennes chennes merged commit d79d3c0 into FreeCAD:main Apr 19, 2024
@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 20, 2024

I tested this on Windows today and it appears to work -- at least, I got no errors, and when I changed the minSize the number of cells in the mesh changed. Is that evidence enough that it is working properly?

Yes, I tested this in the newest weekly and it's working. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: FEM Related to the FEM Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Problem] Missing min element size setting for Netgen FEM mesher

4 participants