Skip to content

Draft: Introduce mouse delay#12624

Merged
chennes merged 2 commits intoFreeCAD:mainfrom
yorikvanhavre:draft-mouse-delay
Mar 11, 2024
Merged

Draft: Introduce mouse delay#12624
chennes merged 2 commits intoFreeCAD:mainfrom
yorikvanhavre:draft-mouse-delay

Conversation

@yorikvanhavre
Copy link
Member

This PR introduces a new "Mouse delay" preferences located under Edit -> Preferences -> Draft -> Grid and Snapping

  • When mouse delay is set to 0, nothing happens, same as how it works now
  • When it's set to a value, ex. 1 second, after you enter a number in one of the coordinate fields in Draft/Arch, the mouse will not change the value anymore during 1 second. After that, it resumes normal working.
  • If you set the value to something very high, for ex. 3600 (one hour), mouse movement will be disabled after you start entering numeric values, until the command is finished.

This fixes #11807

@github-actions github-actions bot added the Mod: Draft Related to the Draft Workbench label Feb 26, 2024
@4a3
Copy link

4a3 commented Feb 27, 2024

and why the difficulties? I pressed the hotkey. activated the input field. I liked it - I entered enter. no - escape.. and then the interception of the direction does not intersect with the data entry. why are these risks "untimely"?

@yorikvanhavre
Copy link
Member Author

and why the difficulties? I pressed the hotkey. activated the input field. I liked it - I entered enter. no - escape.. and then the interception of the direction does not intersect with the data entry. why are these risks "untimely"?

Could you explain better? I don't understand what is happening

@kaiwas
Copy link
Member

kaiwas commented Mar 2, 2024

"Mouse delay" preferences located under Edit -> Preferences -> Draft -> Grid and Snapping

How can I play with this?
I did not find the specified settings in the weekly build dated March 1st.
Or should we just wait some more?

@kaiwas
Copy link
Member

kaiwas commented Mar 2, 2024

I didn’t immediately realize that this change needed to be compiled independently.
This is too hard for me. I'll wait for this change in the main branch.

@yorikvanhavre
Copy link
Member Author

I will change the default to be something else than 0 so people notice the feature

@kaiwas
Copy link
Member

kaiwas commented Mar 10, 2024

I will change the default to be something else than 0 so people notice the feature

Can you make these changes into the weekly build?

@yorikvanhavre
Copy link
Member Author

As soon as they are merged they'll be in the next weekly build

For next M3: This should be good to go!

@chennes chennes merged commit b2f1add into FreeCAD:main Mar 11, 2024
@kaiwas
Copy link
Member

kaiwas commented Mar 12, 2024

I tested the algorithm a little in the weekly build dated March 11th.
It seems this only works in the draft workbench.
for example, when adding walls in arch/bim (as one of the possible examples) - it does not work (((
(in the settings I set it to 50 seconds)

I would really like some kind of global setting. So that the mouse does not affect the input data anywhere by default.

Often the mouse only sets the direction, but the final value is entered in the input fields, and not by the position of the mouse. This is done in all CAD systems that I have encountered.

simplescreenrecorder-2024-03-12_11.55.56.mp4

@yorikvanhavre
Copy link
Member Author

It's indeed only working in Draft. Let's see if it behaves well and nobody complains and we can see how to extend to other places...

@kaiwas
Copy link
Member

kaiwas commented Mar 12, 2024

How long will you have to wait for "feedback"? What if it doesn’t exist (simply because no one uses the draft)?
Today is kind of a bad news day.
I give up.

In the sketcher, entire basic tools are removed, replacing them with some kind of multitools without any tests.
If there are dissatisfied people, it won’t take long to remove this setting.
And such an important problem as data loss (which is not found in any other program) will take years to solve.
All hope lies only in you.

@kaiwas
Copy link
Member

kaiwas commented Mar 12, 2024

Another difficulty arises.
At first, for a very long time I could not understand why the same things work differently in different workbenches.
Somewhere the selection is added with Shift, somewhere with Ctrl, somewhere just by clicking. There “it” works like this, here it works “differently”.

The proposed soft-test will simply add to the heterogeneity program.

Maybe make this change for sure and ask as many people as possible to test it on the forum? This will make it clear pretty quickly whether this is good or not.

  1. In addition, the setting is easy to disable. And she doesn't break anything.
  2. Version 0.22 is not yet released and is perceived by most as a test version.

It seems to me it's time to take a break from FreeCAD out for a while.

@kaiwas
Copy link
Member

kaiwas commented May 17, 2024

It's indeed only working in Draft

Hi!
I noticed strange behavior when mouse delay is enabled.
If I enter data and accidentally move the mouse, the model disappears (hide) until I confirm the entered data with a button.
Video demonstration.

video-2024-05-17_17.12.54.mp4

However, despite this, it became better than it was. It is possible to save data at least sometimes (it’s a pity that this does not work when creating ARCH objects). To save zero coordinates at the time of object creation, you have to move the mouse through the panels (without pointing at the 3D window)

I also ask you to draw your attention to this topic. Is it possible to make sure that the data is not reset after each operation? There is almost never a need to move to zero.
#12500
#13334

@yorikvanhavre
Copy link
Member Author

I can ´t see your video...
But I think what you are describing refers to the two other issues you linked, and not this one?

@kaiwas
Copy link
Member

kaiwas commented May 22, 2024

I can ´t see your video...

For some reason the video was broken.
I wrote it down again.
A way to reproduce.

  1. Enter data into the input fields to move
  2. slightly move the cursor in the 3D window (the object disappears).
  3. Confirm the data with the "Enter point" button (the object appears)
video-2024-05-22_11.55.17.mp4

@yorikvanhavre
Copy link
Member Author

Ok I could reproduce the problem. Indeed some tools (Move and Rotate basically) switch their ghosts off and on at each mouse move, and they aren't turned back on if the mouse delay is active. I'll work on a fix

@kaiwas
Copy link
Member

kaiwas commented May 29, 2024

@yorikvanhavre Hello.
It seems that the Trimex tool cannot be applied if you enter data into the fields. There is no "OK" or "Apply" button. But clicking the mouse does not lead to any result.

This problem may occur in all tools where there is only a “close” button/

Trimex.mp4

@yorikvanhavre
Copy link
Member Author

@kaiwas that's a separate problem... Could you open a new issue? This one has been closed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Draft Related to the Draft Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Problem] mouse overrides inputs in draft

4 participants