Fem: Update constraint symbols when moving reference shape - fixes #6093#12527
Conversation
github-actions
bot
added
Mod: FEM
|
It seems that this fixes the constraint symbol display but the mesh is shown in an old place (where the part was before changing the placement). Same with the results and results mesh. Initially, I also had an error suggesting that the constraint is misplaced but I can’t recreate it now. It can be important because the issue description mentions that not only the symbols were misplaced but also the constraints were not applied properly. |
Good news regarding this issue. It's mostly resolved. Works with arbitrary nested containers and arbitrary placement.
|
marioalexis84
force-pushed
the
fem-update_constraint_symbols
branch
from
1b55e66 to
5938489
Compare
|
@FEA-eng could you test? |
I tested this and can confirm that it works now. |
3 participants
@chennes
Now the symbols are updated even having the shape within a sequence of nested containers.
some points:
FEM is currently a bit inflexible and does not take into account the possibility of working with shapes inside App::Part or PartDesign::Body. This pull request unmasks other bugs that appear during the workflow.
This PR is marked as a draft to perform some tests.
The boost connection will be replaced by a DocumentObserver.
The first commit resolves a bug in Part. SetRotation and SetTranslation convert the transformation into pure rotation and pure translation, respectively, so they are replaced by SetRotationPart and SetTranslationPart.
@FEA-eng Could you do some tests?