Fem: Fix restoring old Tie constraint and add support for cyclic symmetry - fixes #12155#12289
Conversation
|
@marioalexis84 Thank you very much for implementing this. I tested it on Ubuntu and it's working properly. Btw. I hope that you don't mind if I ask but could you take a look at this issue too: #10864 ? As explained in the issue description, it seems to be easy to implement (for someone familiar with the source code so not for me, unfortunately). It's just a matter of adding one option to SolverCcxTools and internally replacing element names and SHELL with SOLID in the section definition (thickness is already there). Then ensuring zero Z coordinates for nodes. Just some input file swaps basically. Quite a few people asked for those analyses (especially axisymmetric) recently so it would be great to have them implemented. @chennes Can you merge this PR ? |
That would be more than awesome. I’m so glad you’re doing so much for this workbench. I gave those issues some priority here: FEM Roadmap but of course it’s subjective and totally up to you. I chose #10864 as particularly interesting because it seems to be rather easy to implement while adding a lot of functionality to the FEM workbench. |
3 participants
Add support for cyclic symmetry.
This also fixes the loading of the old Tie constraint object prior to #12133 since in that commit the existence check for the
Adjustproperty was not added when restoring the object (currently old files are loaded without adding this property).Normally I would have generated two pull requests, one for the correction and another to add the cyclic symmetry, but since some helper functions are added for use in creating properties and restoring the
DocumentObject, I decided to put it together in a single commit.The idea of the helper functions is to avoid code duplication and string comparison that usually occurs in
onDocumentRestoredwhen modifications are made to the properties.The location of the axis of symmetry is obtained by applying the placement transformation to the
Z versor(similar to what is done with the lines inPartmodule).Still is needed add some view providers, options to task panel and automatically calculate the axis of symmetry from the planes defined by the surfaces that define the sector angle.
@FEA-eng