Skip to content

[Gui] Add 20, 25 and 30px marker sizes to assist users of 4K screens#11524

Merged
wwmayer merged 1 commit intoFreeCAD:mainfrom
Syres916:Larger_Marker_Sizes
Nov 25, 2023
Merged

[Gui] Add 20, 25 and 30px marker sizes to assist users of 4K screens#11524
wwmayer merged 1 commit intoFreeCAD:mainfrom
Syres916:Larger_Marker_Sizes

Conversation

@Syres916
Copy link
Contributor

This isn't the first time this has been requested on the forum but see the most recent discussion https://forum.freecad.org/viewtopic.php?t=82927

As I only have a 2K screen they do appear quite large but I'm aware of how much that will be reduced on higher DPI.

Hopefully one of the devs or self compile users with a 4K screen can test this on their setup.

@github-actions github-actions bot added the Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Nov 25, 2023
@wwmayer wwmayer merged commit 00826ab into FreeCAD:main Nov 25, 2023
@Roy-043
Copy link
Contributor

Roy-043 commented Nov 25, 2023

The FreeCADGui.getMarkerIndex function needs to be updated to support the new sizes. Currently it only goes to 9px.

In Draft we also use HOURGLASS_FILLED_9_9. Maybe that shape can be added at higher resolutions as well?

@wwmayer
Copy link
Contributor

wwmayer commented Nov 25, 2023

#11528

@Roy-043
Copy link
Contributor

Roy-043 commented Dec 8, 2023

The Draft WB now uses the MarkerSize preference for snap and tracker markers (#11688) and also these new sizes. Everything seems to work well except the diamondFilled20_marker. That marker displays as a 'scratched out' square for some reason. I have checked all sizes from 13 - 30 px. Only the 20px marker is affected. The filled diamond marker is used for Draft Snap Midpoint.
diamondFilled20_marker

Roy-043 added a commit to Roy-043/FreeCAD that referenced this pull request Dec 9, 2023
Also made DIAMOND_FILLED_25_25 sharper.

See: FreeCAD#11524 (comment)
yorikvanhavre pushed a commit that referenced this pull request Dec 11, 2023
Also made DIAMOND_FILLED_25_25 sharper.

See: #11524 (comment)
kpemartin pushed a commit to kpemartin/FreeCAD that referenced this pull request Dec 11, 2023
Also made DIAMOND_FILLED_25_25 sharper.

See: FreeCAD#11524 (comment)
@Syres916 Syres916 deleted the Larger_Marker_Sizes branch February 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants