Draft: improve Snap bar show-hide preference#11512
Merged
yorikvanhavre merged 1 commit intoFreeCAD:mainfrom Nov 24, 2023
Merged
Draft: improve Snap bar show-hide preference#11512yorikvanhavre merged 1 commit intoFreeCAD:mainfrom
yorikvanhavre merged 1 commit intoFreeCAD:mainfrom
Conversation
This PR replaces the showSnapBar and hideSnapBar preferences with a single new preference: SnapBarShowOnlyDuringCommands. Additonally: Improved some param observer callbacks.
Roy-043
force-pushed
the
Draft-improve-Snap-bar-show-hide-preference
branch
from
e796952 to
1c8f34b
Compare
yorikvanhavre
approved these changes
Nov 24, 2023
Member
yorikvanhavre
left a comment
yorikvanhavre
left a comment
There was a problem hiding this comment.
Very welcome change... indeed it was confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the showSnapBar and hideSnapBar preferences with a single new preference: SnapBarShowOnlyDuringCommands.
Additonally:
Improved some param observer callbacks.