Skip to content

[Sketcher] Improve angle & radius constraint rendering#11507

Merged
chennes merged 3 commits intoFreeCAD:mainfrom
Ondsel-Development:constr_primitives
Dec 4, 2023
Merged

[Sketcher] Improve angle & radius constraint rendering#11507
chennes merged 3 commits intoFreeCAD:mainfrom
Ondsel-Development:constr_primitives

Conversation

@PaddleStroke
Copy link
Contributor

@PaddleStroke PaddleStroke commented Nov 24, 2023

This PR improve the rendering of the (2lines) angle and radius SoDatumLabel
image
image

@github-actions github-actions bot added Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: Sketcher Related to the Sketcher Workbench labels Nov 24, 2023
@PaddleStroke PaddleStroke changed the title [Sketcher] Improve angle constraint rendering [Sketcher] Improve angle & radius constraint rendering Nov 24, 2023
@PaddleStroke
Copy link
Contributor Author

PaddleStroke commented Nov 24, 2023

@FlachyJoe please check here, I have added arc helpers for radius constraints. This would be the best for arc - something distances (#9166)
I can make this when your PR and this PR merges. Or add on top of this one if your PR merge first.

@obelisk79
Copy link
Contributor

This is quite interesting. Seems like an improvement based off what I see in the screenshots.

@PaddleStroke
Copy link
Contributor Author

@wwmayer this is touching SoDatumLabel which you know so perhaps you would be willing to review this PR please ?

@wwmayer
Copy link
Contributor

wwmayer commented Nov 24, 2023

The changes in SoDatumLabel are OK.

@PaddleStroke
Copy link
Contributor Author

@adrianinsaval care to check this one out? Werner already reviewed changes in SoDatumLabel

@FlachyJoe
Copy link
Contributor

This would be the best for arc - something distances

Certainly yes ! But in fact arc helper is needed for all the constraints, see floating icons for tangencies in #9166 (comment)

@PaddleStroke
Copy link
Contributor Author

Do those floating icons actually happen in real life work ? I am not sure there are so many tangencies to arcs in random positions that would end up floating.
If it does happen and is a real issue, then a possibility would be to draw arc helpers for geometric constraints when needed as well. But this may be much more work as geometric constraints do not have soDatumLabels (afaik).

@FlachyJoe
Copy link
Contributor

@PaddleStroke we understand the left tangent only with the right part of the sketch
image

@PaddleStroke
Copy link
Contributor Author

I see.
But in these cases, do you think the user is going to toggle arc helpers ? It's likely that if you don't understand the sketch you will select associated geometries instead. I'm not sure the arc helpers would help much to understand in the sketch you screenshoted.

@PaddleStroke
Copy link
Contributor Author

PaddleStroke commented Nov 28, 2023

But yes arc helpers similar to the one I made for radius in this PR would probably help I guess as you would have only a red line between the arc and the contraint.

@maxwxyz
Copy link
Collaborator

maxwxyz commented Dec 24, 2023

@PaddleStroke did something mess with this? It is currently not working in the latest weekly build:

grafik

Maybe #11777 or related to: #11826

OS: Windows 11 build 22631
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.35449 (Git)
Build type: Release
Branch: main
Hash: f3fa2ba9c9b1999e5c32d3ae544481b6e17553bb
Python 3.10.13, Qt 5.15.8, Coin 4.0.2, Vtk 9.2.6, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * 3DfindIT 1.2.0
  * BIM 2021.12.0
  * CfdOF 1.24.9
  * CurvedShapes 1.0.5
  * Curves 0.6.19
  * Defeaturing 1.2.1
  * fasteners 0.4.75
  * FEMbyGEN 2.0.0
  * freecad.gears 1.0.0
  * freecad_metal_workbench 0.0.1
  * OpenDark 2023.12.17
  * sheetmetal 0.3.13
  * woodworking 0.21.1.33694

@PaddleStroke
Copy link
Contributor Author

@maxwxyz hmm maybe someone reverted these changes when trying to fix #11777 ?
Or perhaps it was broken by #9166 @FlachyJoe any idea about this?

@maxwxyz
Copy link
Collaborator

maxwxyz commented Jan 7, 2024

@FlachyJoe it is still present, shall I create an issue?
grafik

@FlachyJoe
Copy link
Contributor

FlachyJoe commented Jan 7, 2024

@maxwxyz Not sure why but 2 commits were lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Mod: Sketcher Related to the Sketcher Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants