[Sketcher] Improve angle & radius constraint rendering#11507
[Sketcher] Improve angle & radius constraint rendering#11507chennes merged 3 commits intoFreeCAD:mainfrom
Conversation
|
@FlachyJoe please check here, I have added arc helpers for radius constraints. This would be the best for arc - something distances (#9166) |
|
This is quite interesting. Seems like an improvement based off what I see in the screenshots. |
|
@wwmayer this is touching SoDatumLabel which you know so perhaps you would be willing to review this PR please ? |
9ab722f to
a2c909f
Compare
|
The changes in SoDatumLabel are OK. |
|
@adrianinsaval care to check this one out? Werner already reviewed changes in SoDatumLabel |
Certainly yes ! But in fact arc helper is needed for all the constraints, see floating icons for tangencies in #9166 (comment) |
|
Do those floating icons actually happen in real life work ? I am not sure there are so many tangencies to arcs in random positions that would end up floating. |
|
@PaddleStroke we understand the left tangent only with the right part of the sketch |
|
I see. |
|
But yes arc helpers similar to the one I made for radius in this PR would probably help I guess as you would have only a red line between the arc and the contraint. |
|
@PaddleStroke did something mess with this? It is currently not working in the latest weekly build: Maybe #11777 or related to: #11826 |
|
@maxwxyz hmm maybe someone reverted these changes when trying to fix #11777 ? |
|
@FlachyJoe it is still present, shall I create an issue? |
|
@maxwxyz Not sure why but 2 commits were lost. |



This PR improve the rendering of the (2lines) angle and radius SoDatumLabel

