[TechDraw] Fixes #7317 - Calculate Area of Arbitrary Faces#11473
Merged
WandererFan merged 3 commits intoFreeCAD:mainfrom Nov 24, 2023
Merged
[TechDraw] Fixes #7317 - Calculate Area of Arbitrary Faces#11473WandererFan merged 3 commits intoFreeCAD:mainfrom
WandererFan merged 3 commits intoFreeCAD:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements #7317 so face area computation is not limited to polygons. I have tested several shapes with arcs and bezier curves, the computation seems to work fine.
There are other 2 minor changes. First is a proposed icon change. I have tried to create an icon, which would better represent the "face area" operation. From my point of view it looks better, however if the old one stays, I am not offended!
The second additional change is converting length units ending with ^2 (squared) to length units with ² superscript. E.g. "mm^2" → "mm²". Again, for me this looks much better, but definitely it is not something extra important.
I believe the change will fulfill the expectations, in case of any issues please let me know.