Skip to content

[TechDraw] - Line Decoration Improvements#11188

Merged
WandererFan merged 1 commit intoFreeCAD:mainfrom
pavltom:line_decoration_improvements
Oct 26, 2023
Merged

[TechDraw] - Line Decoration Improvements#11188
WandererFan merged 1 commit intoFreeCAD:mainfrom
pavltom:line_decoration_improvements

Conversation

@pavltom
Copy link
Contributor

@pavltom pavltom commented Oct 26, 2023

This PR improves line decoration handling:

  1. Double clicking on an edge invokes Line Decoration dialog. This aims to improve productivity when creating a drawing. The changes involved are in files QGIEdge.h and QGIEdge.cpp .
  2. When the Line Decoration dialog is invoked, all updates to style are immediately reflected. This is perfect. However when Cancel is pressed, the old style values were not stored anywhere and in fact, there was no difference between pressing OK or Cancel. It just closed the dialog. With this PR, the line styles are fully preserved and restored, if the user decides to press Cancel. These changes are contained in TaskLineDecor.h and taskLineDecor.cpp files.
  3. Small fix of earlier refactorization. Without setting the pen style, all lines are drawn as solid. Code change in QGIPrimPath:311.

I hope you will find this addition useful, in case of any issues or questions, please leave a comment!

@github-actions github-actions bot added the Mod: TechDraw Related to the TechDraw Workbench label Oct 26, 2023
@WandererFan WandererFan merged commit ded89f5 into FreeCAD:main Oct 26, 2023
@WandererFan
Copy link
Contributor

Thank you! This was on my list and now I can cross it off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mod: TechDraw Related to the TechDraw Workbench

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants