Gui: Register overlay search path from preference packs#11039
Merged
chennes merged 1 commit intoFreeCAD:mainfrom Oct 14, 2023
Merged
Gui: Register overlay search path from preference packs#11039chennes merged 1 commit intoFreeCAD:mainfrom
chennes merged 1 commit intoFreeCAD:mainfrom
Conversation
This commit adds "<mod>/overlay" path to search paths of "overlay" prefix. This allows preference packs to register custom overlay stylesheets. Fixes: FreeCAD#11023
github-actions
bot
added
the
Mod: Core
Contributor
|
I have tested and confirmed that this works. |
Member
|
OK, I'll merge this, but I agree that we should reconsider this implementation to allow direct specification of those paths. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
"<mod>/overlay"path to search paths of "overlay" prefix. This allows preference packs to register custom overlay stylesheets.I think that we should think about better ways of doing that kind of stuff. Package metadata could include elements like
which should enable package developers to have better control over the search paths. This should however be done in another request and issue.
Fixes: #11023