Skip to content

StartPage: Visual overhaul and CSS fixes#10391

Merged
chennes merged 3 commits intoFreeCAD:masterfrom
qewer33:master
Aug 27, 2023
Merged

StartPage: Visual overhaul and CSS fixes#10391
chennes merged 3 commits intoFreeCAD:masterfrom
qewer33:master

Conversation

@qewer33
Copy link
Contributor

@qewer33 qewer33 commented Aug 27, 2023

This PR visually overhauls and modernizes the design of the StartPage (without going too far from the current design and layout) and addresses the issues mentioned in #10381.

Below are a couple of screenshots:

Screenshot_20230827_184509

Screenshot_20230827_184520

Screenshot_20230827_184526

A couple of notes:

  • This PR doesn't add or remove any functionality for the StartPage
  • My previous PR that added "new file templates" (StartPage: Add new file templates and fix javascript error #10171) had some regressions caused by reformatting of the CSS, this PR fixes those
  • This PR styles the scrollbar so the "hide scrollbar" option (which seems to have been initially added because the scrollbar looked inconsistent with the rest of the StartPage) could be considered unnecessary now. Open to discussion
  • This PR adds a "Welcome to FreeCAD" text that should be translated
  • The title and tooltip of the Blog tab is translatable now

@chennes
Copy link
Member

chennes commented Aug 27, 2023

The Start page now fails W3C validation with the following report (you'll get better info if you submit it to the validator directly, the CI mangles the report a little):

ERROR: 'No space between attributes.'
ERROR: 'Attribute \u201cfreecad\u201d not allowed on element \u201cimg\u201d at this point.'
INFO: 'Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.'
INFO: 'Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.'
INFO: 'Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.'
INFO: 'Trailing slash on void elements has no effect and interacts badly with unquoted attribute values.'

@qewer33
Copy link
Contributor Author

qewer33 commented Aug 27, 2023

The Start page now fails W3C validation with the following report (you'll get better info if you submit it to the validator directly, the CI mangles the report a little)

Yep, just saw. It was a double quote typo. Should be fixed now

@chennes chennes merged commit 0a093e1 into FreeCAD:master Aug 27, 2023
@qewer33 qewer33 mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qewer33 @chennes