Skip to content

Conversation

@jpdriver
Copy link
Contributor

@jpdriver jpdriver commented Feb 5, 2022

  • although there was a comment block outlining the changes, it was difficult to grok the actual changes in our custom prism-core.js vs the original file
  • adopting patch-package allows us to explicitly see what changes have been made and ties them to a specific prismjs target version
  • this also avoids the additional headache of the modified file having been additionally modified by Prettier
  • also updates prismjs so that the current patch targets the latest release

@jpdriver jpdriver merged commit 64617ea into master Feb 5, 2022
@jpdriver jpdriver deleted the jp-patch-package branch February 5, 2022 01:03
This was referenced Feb 8, 2022
@jpdriver jpdriver mentioned this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants