Skip to content

Add show reading progress function / 增加显示阅读进度功能#2768

Merged
revonateB0T merged 9 commits intoFooIbar:mainfrom
AdiEcho:reading_progress
Dec 1, 2025
Merged

Add show reading progress function / 增加显示阅读进度功能#2768
revonateB0T merged 9 commits intoFooIbar:mainfrom
AdiEcho:reading_progress

Conversation

@AdiEcho
Copy link
Copy Markdown
Contributor

@AdiEcho AdiEcho commented Nov 28, 2025

resolve #2277

On the gallery browsing page and the download page, displaying the reading progress is supported. This feature needs to be enabled in Settings -> EH -> Show reading progress.

在画廊浏览页面与下载页面支持显示阅读进度，该功能需要在 设置->EH->显示阅读进度 中开启

gallery browsing page:
Show reading progress only after reading, keep the original format beforehand

画廊浏览页面：
仅在阅读后显示阅读进度，在未阅读时保持原格式显示

image

Download page:
Add reading progress only to galleries that have been fully downloaded and read.

下载页面：
仅在已完成下载且阅读后的画廊列表中添加阅读进度

image

FooIbar
FooIbar reviewed Nov 29, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@FooIbar FooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前考虑过这个，但是有点问题就先放着了，不过我忘了什么问题了

@FooIbar FooIbar requested a review from revonateB0T November 29, 2025 07:35
@AdiEcho AdiEcho requested a review from FooIbar November 29, 2025 17:41
FooIbar
FooIbar reviewed Nov 30, 2025
View reviewed changes
revonateB0T
revonateB0T reviewed Nov 30, 2025
View reviewed changes
@AdiEcho AdiEcho requested a review from revonateB0T December 1, 2025 09:28
@AdiEcho
Copy link
Copy Markdown
Contributor Author

AdiEcho commented Dec 1, 2025

之前没细看设置，刚看到有显示画廊页数 这个开关，将显示阅读进度调整成打开显示画廊页数 才显示了。
下载页面如果打开了显示画廊页数 无论什么状态也显示页数了
看看还有没有什么问题

@AdiEcho AdiEcho requested a review from FooIbar December 1, 2025 09:33
@FooIbar FooIbar closed this Dec 1, 2025
@FooIbar FooIbar reopened this Dec 1, 2025
FooIbar
FooIbar reviewed Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@FooIbar FooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跑一下

./gradlew spotlessApply

@AdiEcho AdiEcho requested a review from FooIbar December 1, 2025 12:22
FooIbar
FooIbar reviewed Dec 1, 2025
View reviewed changes
@AdiEcho AdiEcho requested a review from FooIbar December 1, 2025 14:44
FooIbar
FooIbar reviewed Dec 1, 2025
View reviewed changes
FooIbar
FooIbar approved these changes Dec 1, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@FooIbar FooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FooIbar FooIbar closed this Dec 1, 2025
@FooIbar FooIbar reopened this Dec 1, 2025
@revonateB0T revonateB0T merged commit 0ff40d3 into FooIbar:main Dec 1, 2025
4 checks passed
@AdiEcho AdiEcho deleted the reading_progress branch December 1, 2025 17:02
@yinzhefuyun
Copy link
Copy Markdown

yinzhefuyun commented Dec 2, 2025

所以这个版本已经下载完成后还有一个▶️按钮是bug还是特性？点击就弹出下载结束，理论上下载结束不需要这个按钮吧，只有下载未完成才需要吧

@FooIbar
Copy link
Copy Markdown
Owner

FooIbar commented Dec 2, 2025

所以这个版本已经下载完成后还有一个▶️按钮是bug还是特性？点击就弹出下载结束，理论上下载结束不需要这个按钮吧，只有下载未完成才需要吧

这是预期行为，因为数据库和文件系统状态可能不一致，比如用户在应用外误删了已下载的文件
而且在开启保存为 CBZ 压缩包后重新执行下载会打包之前下载的内容

@yinzhefuyun
Copy link
Copy Markdown

yinzhefuyun commented Dec 2, 2025 •
edited
Loading

所以这个版本已经下载完成后还有一个▶️按钮是bug还是特性？点击就弹出下载结束，理论上下载结束不需要这个按钮吧，只有下载未完成才需要吧

这是预期行为，因为数据库和文件系统状态可能不一致，比如用户在应用外误删了已下载的文件 而且在开启保存为 CBZ 压缩包后重新执行下载会打包之前下载的内容

主要是感觉看起来有点歧义，看到32/64P，然后下面一个▶️，我就会在想这个▶️是继续下载还是继续阅读如果是你说的这个建议图标换成🔄(刷新那个两个剪头组成的⭕)

@Mapaler
Copy link
Copy Markdown
Contributor

Mapaler commented Dec 2, 2025

只有这个P数不太直观啊。可以做一个背景色或者底部进度条吗？
Image

@yinzhefuyun
Copy link
Copy Markdown

yinzhefuyun commented Dec 2, 2025

只有这个P数不太直观啊。可以做一个背景色或者底部进度条吗？ Image

你是想做的和播放器一样灰色是缓存，有颜色是当前位置？P肯定要有的，要不然是薄本还是合集还是插画集都分辨不出来

@Mapaler
Copy link
Copy Markdown
Contributor

Mapaler commented Dec 2, 2025

只有这个P数不太直观啊。可以做一个背景色或者底部进度条吗？ Image

你是想做的和播放器一样灰色是缓存，有颜色是当前位置？P肯定要有的，要不然是薄本还是合集还是插画集都分辨不出来

我想的不同的颜色是用来表达是否看完，因为我可以一眼忽略看完了的。我更喜欢方案A，当然颜色是我随便设的，我只是用图片编辑软件做的概念图。

@FooIbar
Copy link
Copy Markdown
Owner

FooIbar commented Dec 2, 2025

主要是感觉看起来有点歧义，看到32/64P，然后下面一个▶️，我就会在想这个▶️是继续下载还是继续阅读如果是你说的这个建议图标换成🔄(刷新那个两个剪头组成的⭕)

合理

只有这个P数不太直观啊。可以做一个背景色或者底部进度条吗？

太丑

@FooIbar FooIbar mentioned this pull request Dec 2, 2025
Merged
@Mapaler
Copy link
Copy Markdown
Contributor

Mapaler commented Dec 2, 2025

现在只有数字，辨认起来有点吃力
IMG_20251203_010635.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@revonateB0T revonateB0T revonateB0T approved these changes

@FooIbar FooIbar FooIbar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[功能请求]在下载列表内显示阅读进度

5 participants

@AdiEcho @yinzhefuyun @FooIbar @Mapaler @revonateB0T