Skip to content

Revert "Kill Legacy TextView (#1786)"#2004

Merged
FooIbar merged 1 commit intomainfrom
fb/comment
Dec 7, 2024
Merged

Revert "Kill Legacy TextView (#1786)"#2004
FooIbar merged 1 commit intomainfrom
fb/comment

Conversation

@FooIbar
Copy link
Copy Markdown
Owner

@FooIbar FooIbar commented Dec 7, 2024

This reverts commit 62927cb

Reason for revert: Bad performance
@FooIbar FooIbar requested a review from revonateB0T December 7, 2024 14:12
@revonateB0T
Copy link
Copy Markdown
Collaborator

I don't think we should give up on such corner use case, let's try optimize it or at least report to upstream.
Have you profiled it? Share some callstack sample graph

@FooIbar
Copy link
Copy Markdown
Owner Author

FooIbar commented Dec 7, 2024

I don't think we should give up on such corner use case, let's try optimize it or at least report to upstream. Have you profiled it? Share some callstack sample graph

We can reland it if it's fixed by upstream.
image

Copy link
Copy Markdown
Collaborator

@revonateB0T revonateB0T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issuetracker link?

@FooIbar
Copy link
Copy Markdown
Owner Author

FooIbar commented Dec 7, 2024

Issuetracker link?

Will look into it further.

@FooIbar FooIbar merged commit bd24630 into main Dec 7, 2024
@FooIbar FooIbar deleted the fb/comment branch December 7, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants