Cleanup to not handle memory allocation failure#1882
Merged
revonateB0T merged 2 commits intomainfrom Nov 4, 2024
Merged
Conversation
FooIbar
reviewed
Nov 4, 2024
FooIbar
approved these changes
Nov 4, 2024
Collaborator
Author
|
|
FooIbar
approved these changes
Nov 4, 2024
Owner
FooIbar
left a comment
FooIbar
left a comment
There was a problem hiding this comment.
Unrelated, but although we return 0 on failure here, 0 is not considered a failure in ArchivePageLoader.
Collaborator
Author
Anyway they are the same meaning, "we cannot find sth. to read" |
Owner
0 is treated as a success there so no error message will be displayed, just a blank screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.