Rolling number POC, convert page index#1740
Merged
revonateB0T merged 28 commits intomainfrom Oct 17, 2024
Merged
Conversation
FooIbar
reviewed
Oct 16, 2024
Owner
FooIbar
left a comment
FooIbar
left a comment
There was a problem hiding this comment.
It's kinda weird when changing from 9 to 0.
added 3 commits
October 16, 2024 22:30
Collaborator
Author
Resolved |
FooIbar
reviewed
Oct 16, 2024
app/src/main/kotlin/com/hippo/ehviewer/ui/main/RollingNumber.kt
Outdated
Show resolved
Hide resolved
FooIbar
reviewed
Oct 17, 2024
Owner
FooIbar
left a comment
FooIbar
left a comment
There was a problem hiding this comment.
When a new digit is required, it will show empty -> 0 -> 1 briefly, but that's minor.
app/src/main/kotlin/com/hippo/ehviewer/ui/main/RollingNumber.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/hippo/ehviewer/ui/main/RollingNumber.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
Then we make 0 null 1 2 3 4 5 6 7 8 9 0? |
Collaborator
Author
I will refine it with next MR |
Collaborator
Author
Edit: Done |
FooIbar
approved these changes
Oct 17, 2024
app/src/main/kotlin/com/hippo/ehviewer/ui/main/RollingNumber.kt
Outdated
Show resolved
Hide resolved
added 2 commits
October 17, 2024 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's almost there, except some offset mistake