Block AD in Large preview#1694
Merged
revonateB0T merged 18 commits intoFooIbar:mainfrom Sep 30, 2024
revonateB0T:asdasdad
Merged
Block AD in Large preview#1694revonateB0T merged 18 commits intoFooIbar:mainfrom revonateB0T:asdasdad
revonateB0T merged 18 commits intoFooIbar:mainfrom
revonateB0T:asdasdad
Conversation
added 4 commits
September 30, 2024 13:08
Collaborator
Author
|
1.Recompose has some problem |
Owner
|
The false negative rate is too high to justify shipping it. |
Collaborator
Author
|
@FooIbar Then I have no idea, any further possibility to improve it? |
Collaborator
Author
|
@revonateB0T If we could improve it later, we just land it as this MR doesn't touch rust code anyway. |
Owner
I think detecting thumbnails is a dead end. |
FooIbar
reviewed
Sep 30, 2024
app/src/main/kotlin/com/hippo/ehviewer/client/data/GalleryInfo.kt
Outdated
Show resolved
Hide resolved
FooIbar
approved these changes
Sep 30, 2024
FooIbar
added a commit
that referenced
this pull request
Oct 27, 2024
This reverts commit 04ee1a6 Reason for revert: Obsoleted by the upcoming changes
FooIbar
added a commit
that referenced
this pull request
Oct 27, 2024
This reverts commit 04ee1a6 Reason for revert: Obsoleted by the upcoming changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.