Skip to content

Temporarily disable shared element transitions#1621

Merged
FooIbar merged 2 commits intomainfrom
fb/set
Sep 13, 2024
Merged

Temporarily disable shared element transitions#1621
FooIbar merged 2 commits intomainfrom
fb/set

Conversation

@FooIbar
Copy link
Copy Markdown
Owner

@FooIbar FooIbar commented Sep 12, 2024

@FooIbar FooIbar requested a review from revonateB0T September 12, 2024 18:54
@revonateB0T
Copy link
Copy Markdown
Collaborator

This is not necessary, just remove SharedTransitionLayout and provide a noop SharedTransitionScope to minimize modification.

@FooIbar
Copy link
Copy Markdown
Owner Author

FooIbar commented Sep 13, 2024

This is not necessary, just remove SharedTransitionLayout and provide a noop SharedTransitionScope to minimize modification.

This is to allow r8 to remove those dead code.

@revonateB0T
Copy link
Copy Markdown
Collaborator

This is not necessary, just remove SharedTransitionLayout and provide a noop SharedTransitionScope to minimize modification.

This is to allow r8 to remove those dead code.

We don't need to remove dead code as we will add it back one day.

@FooIbar FooIbar merged commit 42ed510 into main Sep 13, 2024
@FooIbar FooIbar deleted the fb/set branch September 13, 2024 04:10
revonateB0T pushed a commit that referenced this pull request Nov 14, 2024
revonateB0T added a commit that referenced this pull request Nov 14, 2024
* Revert "Temporarily disable shared element transitions (#1621)"

This reverts commit 42ed510.

* Fixes

* Update EhAsyncThumb.kt

---------

Co-authored-by: Dude so hot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

评论区刷新闪退

2 participants