Skip to content

Implement Shared Element Transition Connector Framework#1614

Merged
revonateB0T merged 7 commits intoFooIbar:mainfrom
revonateB0T:clup
Sep 9, 2024
Merged

Implement Shared Element Transition Connector Framework#1614
revonateB0T merged 7 commits intoFooIbar:mainfrom
revonateB0T:clup

Conversation

@revonateB0T
Copy link
Copy Markdown
Collaborator

No description provided.

@revonateB0T revonateB0T requested a review from FooIbar September 9, 2024 11:42
@revonateB0T revonateB0T linked an issue Sep 9, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Owner

@FooIbar FooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may not want SET in the following scenarios:

  1. Random pick in local favorites
  2. View clipboard URL
  3. Search similar galleries then press back button

@revonateB0T
Copy link
Copy Markdown
Collaborator Author

revonateB0T commented Sep 9, 2024

We may not want SET in the following scenarios:

  1. Random pick in local favorites
  2. View clipboard URL
  3. Search similar galleries then press back button

Maybe I have little idea, we could use something like connector breakers.
Anyway let's merge this and implement the above three things with later MR?

@FooIbar
Copy link
Copy Markdown
Owner

FooIbar commented Sep 9, 2024

We may not want SET in the following scenarios:

  1. Random pick in local favorites
  2. View clipboard URL
  3. Search similar galleries then press back button

Maybe I have little idea, we could use something like connector breakers. Anyway let's merge this and implement the above three things with later MR?

Sure

@revonateB0T revonateB0T merged commit bd5bd1e into FooIbar:main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor shared element transition logic

2 participants