Skip to content

Refactor packaging and remove Fody.nuspec #2.#1313

Merged
tom-englert merged 9 commits into
masterfrom
dev/remove-nuspec
Apr 13, 2025
Merged

Refactor packaging and remove Fody.nuspec #2.#1313
tom-englert merged 9 commits into
masterfrom
dev/remove-nuspec

Conversation

@tom-englert

@tom-englert tom-englert commented Apr 8, 2025

Copy link
Copy Markdown
Member

Refactor packaging and remove Fody.nuspec - second approach, alternative to #1312

@tom-englert tom-englert changed the title Dev/remove nuspec Refactor packaging and remove Fody.nuspec. Apr 8, 2025
@tom-englert
tom-englert requested a review from Copilot April 8, 2025 10:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 36 changed files in this pull request and generated no comments.

Files not reviewed (9)
  • Directory.Build.props: Language not supported
  • Directory.Build.targets: Language not supported
  • Fody.sln: Language not supported
  • Fody/Fody.csproj: Language not supported
  • Fody/Fody.nuspec: Language not supported
  • Fody/build/Fody.targets: Language not supported
  • FodyHelpers/FodyHelpers.csproj: Language not supported
  • FodyPackaging/FodyPackaging.csproj: Language not supported
  • FodyTasks/FodyTasks.csproj: Language not supported
Comments suppressed due to low confidence (2)

FodyTasks/ConfigFileFinder/ConfigFileFinder.cs:1

  • It appears that a BOM character was removed from the beginning of the file. Verify that the file encoding remains consistent with the build process requirements.
public static class ConfigFileFinder

FodyTasks/ConfigFileFinder/ConfigFileFinder.cs:99

  • Ensure that the updated resource reference 'FodyTasks.Properties.Resources.FodyWeavers_SchemaTemplate' correctly points to the desired schema template after the packaging refactor.
var schema = XDocument.Parse(FodyTasks.Properties.Resources.FodyWeavers_SchemaTemplate);

@tom-englert tom-englert changed the title Refactor packaging and remove Fody.nuspec. Refactor packaging and remove Fody.nuspec #2. Apr 8, 2025

@ltrzesniewski ltrzesniewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! 👍

Comment thread Directory.Build.props Outdated
Comment thread SampleWeaver/SampleWeaver.csproj
Comment thread Directory.Build.props
Comment thread FodyHelpers/FodyHelpers.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants