Skip to content

Update cecil to v0.11.6#1304

Merged
ltrzesniewski merged 3 commits into
masterfrom
update-cecil
Nov 15, 2024
Merged

Update cecil to v0.11.6#1304
ltrzesniewski merged 3 commits into
masterfrom
update-cecil

Conversation

@ltrzesniewski

@ltrzesniewski ltrzesniewski commented Nov 13, 2024

Copy link
Copy Markdown
Member

This updates cecil to v0.11.6 in order to properly support stuff like allows ref struct. I'm not sure it's really required, but better stay up to date with the latest changes.


No longer relevant stuff

This includes other changes since I wanted to make it build properly on CI:

  • I had to update Microsoft.Build.Tasks.Core since the old version caused these errors when you have the .NET 9 SDK:

    error NU1903: Warning As Error: Package 'Microsoft.IO.Redist' 6.0.0 has a known high severity vulnerability, GHSA-hq7w-xv5x-g34j
    error NU1903: Warning As Error: Package 'System.Formats.Asn1' 8.0.0 has a known high severity vulnerability, GHSA-447r-wph3-92pm

    This is caused by the new transitive reference checks. Another option would be to disable these by setting <NuGetAuditMode>direct</NuGetAuditMode>.

  • I moved the tests to net9.0 since I was getting this error with the new version of Microsoft.Build.Tasks.Core:

    Error Message: System.IO.FileNotFoundException : Could not load file or assembly 'Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

  • I disabled the Windows VS job because VS 17.12 is not yet available on GitHub runners. I ran it locally though.

  • There are still issues to fix on the other CI platforms, so I'm posting this as a draft and I'll take a look at these.

I'm now wondering if NuGetAuditMode=direct wouldn't have been better, maybe I'll rollback this mess and leave it for later 😅

@ltrzesniewski

Copy link
Copy Markdown
Member Author

It looks like we'll have to wait until all CI runners update their VS version before using net9.0.

I just reverted NuGet audit to direct package references and updated old net6.0 targets to net8.0 in order for everything to build properly.

@ltrzesniewski
ltrzesniewski marked this pull request as ready for review November 13, 2024 21:55
@SimonCropp

Copy link
Copy Markdown
Member

@ltrzesniewski we could use this approach for installing sdks https://github.com/VerifyTests/Verify/blob/main/src/appveyor.yml#L9

but that should not block this PR

@ltrzesniewski

Copy link
Copy Markdown
Member Author

Thanks for the tip! But I'll need to wait for the new VS version to be available anyway, as we're also testing the .NET Framework version of MSBuild. I'll open another PR when it's available. I'll also have to check if updating Microsoft.Build.Tasks.Core won't introduce any breaking change (the major version of the referenced assembly changes apparently).

Does anyone want to include anything else in the next version, or should I just release it? (6.9.0 I suppose)

andrewlock added a commit to DataDog/dd-trace-dotnet that referenced this pull request Apr 29, 2026
Updated [Fody](https://github.com/Fody/Fody) from 6.8.1 to 6.9.3.

<details>
<summary>Release notes</summary>

_Sourced from [Fody's releases](https://github.com/Fody/Fody/releases)._

## 6.9.3

## What's Changed
* Refactor packaging and remove `Fody.nuspec` #​2. by @​tom-englert in
Fody/Fody#1313
* Clean-up unnecessary dependencies. by @​teo-tsirpanis in
Fody/Fody#1316
* Update Verify.Xunit and xunit.runner.visualstudio by @​GeertvanHorrik
in Fody/Fody#1320
* Prevent failure on updating xsd during build by @​GeertvanHorrik in
Fody/Fody#1319


**Full Changelog**: Fody/Fody@6.9.2...6.9.3

## 6.9.2

## What's Changed
* Avoid constructing `StrongNameKeyPair`. by @​teo-tsirpanis in
Fody/Fody#1311

## New Contributors
* @​teo-tsirpanis made their first contribution in
Fody/Fody#1311

**Full Changelog**: Fody/Fody@6.9.1...6.9.2

## 6.9.1

## What's Changed
* Embed a simplified readme in the nuget package by @​tom-englert in
Fody/Fody#1305


**Full Changelog**: Fody/Fody@6.9.0...6.9.1

## 6.9.0

## What's Changed
* Update cecil to v0.11.6 by @​ltrzesniewski in
Fody/Fody#1304


**Full Changelog**: Fody/Fody@6.8.2...6.9.0

## 6.8.2

## What's Changed
* Bump xunit from 2.8.1 to 2.9.0 by @​dependabot in
Fody/Fody#1281
* Bump xunit.runner.visualstudio from 2.8.1 to 2.8.2 by @​dependabot in
Fody/Fody#1282
* Bump Microsoft.NET.Test.Sdk from 17.9.0 to 17.10.0 by @​dependabot in
Fody/Fody#1272
* Add folder name to test weaver by @​GeertvanHorrik in
Fody/Fody#1298


**Full Changelog**: Fody/Fody@6.8.1...6.8.2

Commits viewable in [compare
view](Fody/Fody@6.8.1...6.9.3).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Fody&package-manager=nuget&previous-version=6.8.1&new-version=6.9.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

> **Note**
> Automatic rebases have been disabled on this pull request as it has
been open for over 30 days.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Lock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants