Add folder name to test weaver#1298
Conversation
| bool runPeVerify = true, | ||
| Action<ModuleDefinition>? afterExecuteCallback = null, | ||
| Action<ModuleDefinition>? beforeExecuteCallback = null, | ||
| string? folderName = null, |
There was a problem hiding this comment.
If you move this new parameter to the end, it should be fully backwards compatible
There was a problem hiding this comment.
I have though about it. You mean behind the assemblyName or really at the end? On the long term, I think it's better to keep them together, but short-term would be best to add at the very end.
There was a problem hiding this comment.
I agree the folderName parameter should be put at the very end, this avoids a breaking change.
ltrzesniewski
left a comment
There was a problem hiding this comment.
I had a very similar issue in InlineIL, and I had to basically rewrite WeaverTestHelper, so I completely understand the need for this change. 🙂
| bool runPeVerify = true, | ||
| Action<ModuleDefinition>? afterExecuteCallback = null, | ||
| Action<ModuleDefinition>? beforeExecuteCallback = null, | ||
| string? folderName = null, |
There was a problem hiding this comment.
I agree the folderName parameter should be put at the very end, this avoids a breaking change.
|
Updated the PR based on feedback. Thanks! |
Updated [Fody](https://github.com/Fody/Fody) from 6.8.1 to 6.9.3. <details> <summary>Release notes</summary> _Sourced from [Fody's releases](https://github.com/Fody/Fody/releases)._ ## 6.9.3 ## What's Changed * Refactor packaging and remove `Fody.nuspec` #2. by @tom-englert in Fody/Fody#1313 * Clean-up unnecessary dependencies. by @teo-tsirpanis in Fody/Fody#1316 * Update Verify.Xunit and xunit.runner.visualstudio by @GeertvanHorrik in Fody/Fody#1320 * Prevent failure on updating xsd during build by @GeertvanHorrik in Fody/Fody#1319 **Full Changelog**: Fody/Fody@6.9.2...6.9.3 ## 6.9.2 ## What's Changed * Avoid constructing `StrongNameKeyPair`. by @teo-tsirpanis in Fody/Fody#1311 ## New Contributors * @teo-tsirpanis made their first contribution in Fody/Fody#1311 **Full Changelog**: Fody/Fody@6.9.1...6.9.2 ## 6.9.1 ## What's Changed * Embed a simplified readme in the nuget package by @tom-englert in Fody/Fody#1305 **Full Changelog**: Fody/Fody@6.9.0...6.9.1 ## 6.9.0 ## What's Changed * Update cecil to v0.11.6 by @ltrzesniewski in Fody/Fody#1304 **Full Changelog**: Fody/Fody@6.8.2...6.9.0 ## 6.8.2 ## What's Changed * Bump xunit from 2.8.1 to 2.9.0 by @dependabot in Fody/Fody#1281 * Bump xunit.runner.visualstudio from 2.8.1 to 2.8.2 by @dependabot in Fody/Fody#1282 * Bump Microsoft.NET.Test.Sdk from 17.9.0 to 17.10.0 by @dependabot in Fody/Fody#1272 * Add folder name to test weaver by @GeertvanHorrik in Fody/Fody#1298 **Full Changelog**: Fody/Fody@6.8.1...6.8.2 Commits viewable in [compare view](Fody/Fody@6.8.1...6.9.3). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Lock <[email protected]>
See #1297