Skip to content

Add Permissions Check to generate-tool-desc Route#5837

Merged
christopherholland-workday merged 1 commit intomainfrom
document-store-permissions
Feb 24, 2026
Merged

Add Permissions Check to generate-tool-desc Route#5837
christopherholland-workday merged 1 commit intomainfrom
document-store-permissions

Conversation

@christopherholland-workday
Copy link
Copy Markdown
Contributor

@christopherholland-workday christopherholland-workday commented Feb 24, 2026

Check documentStores:view permissions for generate-tool-desc:id route

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 24, 2026

Summary of Changes

Hello @christopherholland-workday, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request strengthens API security by integrating a permission check into the generate-tool-desc endpoint. This ensures that only users with the appropriate documentStores:view permissions can access this route, thereby safeguarding data and maintaining controlled access to sensitive operations.

Highlights

  • API Security Enhancement: Implemented a permission check for the generate-tool-desc/:id route, requiring documentStores:view permissions for access.
Changelog
  • packages/server/src/routes/documentstore/index.ts
    • Added checkPermission('documentStores:view') middleware to the generate-tool-desc/:id POST route.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a permission check to the /generate-tool-desc/:id route. My review has identified a related and critical security vulnerability in the controller for this route. It lacks workspace-level access control, potentially leading to an Insecure Direct Object Reference (IDOR) vulnerability. Please see the detailed comment for the recommended fix.

@christopherholland-workday christopherholland-workday merged commit 03c853c into main Feb 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenryHengZJ HenryHengZJ HenryHengZJ approved these changes

@igor-magun-wd igor-magun-wd igor-magun-wd approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yau-wd yau-wd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christopherholland-workday @HenryHengZJ @igor-magun-wd @yau-wd