Skip to content

fix: use cross-env for node env to support windows machine#5835

Merged
jocelynlin-wd merged 1 commit intomainfrom
fix/agentflow-node-env-cross-env
Feb 24, 2026
Merged

fix: use cross-env for node env to support windows machine#5835
jocelynlin-wd merged 1 commit intomainfrom
fix/agentflow-node-env-cross-env

Conversation

@jocelynlin-wd
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jocelynlin-wd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where environment variables were not being correctly interpreted on Windows machines. By integrating the cross-env package, the project's build and development scripts now reliably set the NODE_ENV across all operating systems, enhancing developer experience and ensuring consistent build processes.

Highlights

  • Cross-platform compatibility: Updated the build, dev, and dev:example scripts to utilize cross-env for setting the NODE_ENV environment variable, ensuring consistent behavior across different operating systems, particularly Windows.
  • Dependency management: Added cross-env as a development dependency in packages/agentflow/package.json to support the updated scripts.
Changelog
  • packages/agentflow/package.json
    • Updated build, dev, and dev:example scripts to use cross-env for setting environment variables.
    • Added cross-env to devDependencies.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces cross-env to ensure that setting environment variables in npm scripts is cross-platform compatible, specifically addressing issues on Windows machines. The changes correctly update the build, dev, and dev:example scripts to use cross-env and add it as a development dependency. The implementation is sound and follows standard practices for improving development environment consistency across different operating systems.

Copy link
Copy Markdown
Collaborator

@ginna-baker ginna-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jocelynlin-wd jocelynlin-wd merged commit a4e2bc3 into main Feb 24, 2026
7 checks passed
@yau-wd yau-wd deleted the fix/agentflow-node-env-cross-env branch February 25, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants